Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solution][Endpoint] Allow wildcard in trusted app paths (#97623) #98749

Merged
merged 1 commit into from
Apr 29, 2021
Merged

[7.x] [Security Solution][Endpoint] Allow wildcard in trusted app paths (#97623) #98749

merged 1 commit into from
Apr 29, 2021

Conversation

ashokaditya
Copy link
Member

Backports the following commits to 7.x:

…7623)

* show operator dropdown for path field

refs elastic/security-team/issues/543

* update translation to use consistent values

refs elastic/security-team/issues/543

* update schema to validate path values

refs elastic/security-team/issues/543

* add tests for field and operator values

refs elastic/security-team/issues/543

* review changes

refs elastic/security-team/issues/543

* update schema to enforce dropdown validation for PATH field

refs elastic/security-team/issues/543

* add tests for schema updates

refs 1deab39
refs elastic/security-team/issues/543

* optimise dropdown list for re-renders

refs elastic/security-team/issues/543

* align input fields and keep alignments when resized

refs elastic/security-team/issues/543

* correctly enter operator data on trusted app CRUD

refs elastic/security-team/issues/543

* update tests

refs 2ac56ee
refs elastic/security-team/issues/543

* remove redundant code

review changes

* better type assertion

review changes

* move operator options out of component

- these do not depend on component props and thus no need to have it within a useMemo callback.

- review changes

* derive keys from operator entry field

review changes

* update type

* use custom styles for aligning input fields

review changes

* add a custom type for trusted_apps operator

undo changes from list plugin and server/lib/detection_engine

refs 2ac56ee
refs elastic/security-team/issues/543

* add wildcard entry type

refs elastic/security-team/issues/543
refs #97623 (review)

* use the new entry type

refs elastic/security-team/issues/543
refs #97623 (review)

* update tests

refs elastic/security-team/issues/543
refs #97623 (review)

* update name for wildcard type so that it can be used also for cased inputs

refs elastic/security-team/issues/543
refs f9cb7ed

* update artifacts to support wildcard entries

refs elastic/security-team/issues/543

* add tests for list schemas

refs f9cb7ed
refs elastic/security-team/issues/543

* add placeholders for path values

review changes
/pull/97623#discussion_r620617999

* ignore type check for now

* add type assertion

refs 284352e

* remove unnecessary test

refs 2ac56ee

* fix types

refs f9cb7ed
refs b3f5dc4

* add a note to entries

review changes

refs dbd3532

* remove redundant type assertions

review changes
refs bcf615a
refs b3f5dc4

* move placeholder text logic to utils

review changes /pull/97623#discussion_r621673881

refs 6f2d0d7

* pass the style as prop

review changes

* update api doc

CI check suggestion

* make placeholderText a function expression

review suggestion

/pull/97623/commits/2dc4fd390cf5ea0e4fa67b3f5fc2561cbb29555e

* use semantic names for functions

refs 330731e

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	api_docs/security_solution.json
@ashokaditya ashokaditya enabled auto-merge (squash) April 29, 2021 13:44
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lists 165 166 +1
securitySolution 2181 2182 +1
total +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lists 237 239 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.0MB 7.0MB +1.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lists 210.2KB 210.7KB +521.0B
Unknown metric groups

API count

id before after diff
lists 258 260 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ashokaditya ashokaditya merged commit ed51d31 into elastic:7.x Apr 29, 2021
@ashokaditya ashokaditya deleted the backport/7.x/pr-97623 branch September 15, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants