Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Search] Add logic and routes for Search UI #98641

Merged
merged 11 commits into from
Apr 30, 2021
Merged

[App Search] Add logic and routes for Search UI #98641

merged 11 commits into from
Apr 30, 2021

Conversation

JasonStoltz
Copy link
Member

@JasonStoltz JasonStoltz commented Apr 28, 2021 •
edited
Loading

Summary

Routing and logic for Search UI

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@JasonStoltz JasonStoltz requested review from a team April 28, 2021 15:47
@JasonStoltz JasonStoltz force-pushed the search-ui-plumbing-3 branch from 42343c2 to f684afb Compare April 28, 2021 17:51
@JasonStoltz JasonStoltz changed the title [App Search] Add logic and routes for Search UI, and logic test helper [App Search] Add logic and routes for Search UI Apr 28, 2021
JasonStoltz
JasonStoltz commented Apr 28, 2021
View reviewed changes
x-pack/plugins/enterprise_search/server/lib/enterprise_search_request_handler.test.ts
@@ -100,6 +100,17 @@ describe('EnterpriseSearchRequestHandler', () => {
});
});

it('passes a body if that body is a string buffer', async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this for code coverage which was missing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@JasonStoltz JasonStoltz added v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Apr 28, 2021
cee-chen
cee-chen reviewed Apr 28, 2021
View reviewed changes
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All optional comments, some naming suggestions. Mostly just looking for thoughts or an initial response, feel free to push back - I'll approve after this round!

x-pack/plugins/enterprise_search/server/routes/app_search/reference_application.ts Outdated Show resolved Hide resolved
x-pack/plugins/enterprise_search/server/routes/app_search/reference_application.test.ts Outdated Show resolved Hide resolved
.../plugins/enterprise_search/public/applications/app_search/components/search_ui/search_ui.tsx Outdated Show resolved Hide resolved
...ins/enterprise_search/public/applications/app_search/components/search_ui/search_ui_logic.ts Outdated Show resolved Hide resolved
...ins/enterprise_search/public/applications/app_search/components/search_ui/search_ui_logic.ts Outdated Show resolved Hide resolved
...ins/enterprise_search/public/applications/app_search/components/search_ui/search_ui_logic.ts Outdated Show resolved Hide resolved
...ins/enterprise_search/public/applications/app_search/components/search_ui/search_ui_logic.ts Outdated Show resolved Hide resolved
x-pack/plugins/enterprise_search/server/lib/enterprise_search_request_handler.test.ts
@@ -100,6 +100,17 @@ describe('EnterpriseSearchRequestHandler', () => {
});
});

it('passes a body if that body is a string buffer', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@JasonStoltz JasonStoltz requested a review from cee-chen April 30, 2021 17:58
cee-chen
cee-chen approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeet! Awesome stuff!

@JasonStoltz JasonStoltz enabled auto-merge (squash) April 30, 2021 19:13
@JasonStoltz
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1360 1362 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.0MB 2.0MB +1.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@JasonStoltz JasonStoltz merged commit 7cabbb8 into elastic:master Apr 30, 2021
@kibanamachine kibanamachine mentioned this pull request Apr 30, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 30, 2021
@JasonStoltz @kibanamachine
[App Search] Add logic and routes for Search UI (elastic#98641)
f031e0a
kibanamachine added a commit that referenced this pull request Apr 30, 2021
@kibanamachine @JasonStoltz
[App Search] Add logic and routes for Search UI (#98641) (#98989)
3219a26 
Co-authored-by: Jason Stoltzfus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonStoltz @kibanamachine @cee-chen