Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[visTypeTimeseries] Reduce page load bundle to under 100kB #95873 #97972

Merged
merged 4 commits into from
Apr 27, 2021
Merged

[visTypeTimeseries] Reduce page load bundle to under 100kB #95873 #97972

merged 4 commits into from
Apr 27, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Apr 22, 2021 •
edited
Loading

Closes: #95873

Summary

The visTypeTimeseries plugin is currently 111,347 bytes. To consider #95873 issue closed, the limits.yml should be updated for visTypeTimeseries with the value under 100000.

id before after diff
visTypeTimeseries 110.2KB 25.3KB -84.9KB

@alexwizp alexwizp requested a review from VladLasitsa April 22, 2021 13:03
VladLasitsa
VladLasitsa approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp alexwizp requested a review from stratoula April 26, 2021 08:52
@alexwizp alexwizp self-assigned this Apr 26, 2021
@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) v7.14.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes labels Apr 26, 2021
@alexwizp alexwizp marked this pull request as ready for review April 26, 2021 08:53
@alexwizp alexwizp requested a review from a team April 26, 2021 08:53
@alexwizp alexwizp requested a review from a team as a code owner April 26, 2021 08:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

stratoula
stratoula approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can't find any regression. This PR looks really nice Alex, thank you a lot 😃

@alexwizp alexwizp requested a review from a team as a code owner April 27, 2021 10:51
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from timroes Apr 27, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTimeseries 503 501 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1.6MB 1.7MB +96.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeTimeseries 110.2KB 25.3KB -84.9KB
Unknown metric groups

async chunk count

id before after diff
visTypeTimeseries 11 12 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@timroes
Copy link
Contributor

timroes commented Apr 27, 2021

@elasticmachine run elasticsearch-ci/docs

@alexwizp alexwizp enabled auto-merge (squash) April 27, 2021 13:02
@alexwizp alexwizp merged commit 88288c8 into elastic:master Apr 27, 2021
alexwizp added a commit to alexwizp/kibana that referenced this pull request Apr 27, 2021
@alexwizp
[visTypeTimeseries] Reduce page load bundle to under 100kB elastic#95873
45b6a44 
 (elastic#97972)

* [visTypeTimeseries] Reduce page load bundle to under 100kB elastic#95873

Closes: 95873

* ts-ignore -> ts-expect-error

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	packages/kbn-optimizer/limits.yml
@alexwizp alexwizp mentioned this pull request Apr 27, 2021
Merged
alexwizp added a commit that referenced this pull request Apr 27, 2021
@alexwizp
[visTypeTimeseries] Reduce page load bundle to under 100kB #95873 (#9…
3fd8cfb 
…7972) (#98477)

* [visTypeTimeseries] Reduce page load bundle to under 100kB #95873

Closes: 95873

* ts-ignore -> ts-expect-error

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	packages/kbn-optimizer/limits.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger left review comments

@stratoula stratoula stratoula approved these changes

@VladLasitsa VladLasitsa VladLasitsa approved these changes

@jbudz jbudz jbudz approved these changes

Assignees

@alexwizp alexwizp

Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[visTypeTimeseries] Reduce page load bundle to under 100kB
8 participants
@alexwizp @elasticmachine @kibanamachine @timroes @spalger @jbudz @VladLasitsa @stratoula