Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] add comparison to Instances latency distribution #97710

Merged
merged 4 commits into from
Apr 21, 2021
Merged

[APM] add comparison to Instances latency distribution #97710

merged 4 commits into from
Apr 21, 2021

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Apr 20, 2021 •
edited
Loading

closes #97632

Screen Shot 2021-04-20 at 15 14 03

Screen Shot 2021-04-20 at 15 14 10

Screen Shot 2021-04-20 at 15 14 16

@cauemarcondes cauemarcondes added apm:comparison release_note:skip Skip the PR/issue when compiling release notes v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 20, 2021
@cauemarcondes cauemarcondes marked this pull request as ready for review April 20, 2021 19:40
@cauemarcondes cauemarcondes requested a review from a team as a code owner April 20, 2021 19:40
smith
smith approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@formgeist I'm not color-blind, and I know we're going to use shapes in an upcoming revision, but I do find the grey and blue colors very hard to tell apart.

...k/plugins/apm/public/components/shared/charts/instances_latency_distribution_chart/index.tsx Outdated Show resolved Hide resolved
...k/plugins/apm/public/components/shared/charts/instances_latency_distribution_chart/index.tsx Outdated Show resolved Hide resolved
...k/plugins/apm/public/components/shared/charts/instances_latency_distribution_chart/index.tsx Outdated Show resolved Hide resolved
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Apr 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist
Copy link
Contributor

I'm not color-blind, and I know we're going to use shapes in an upcoming revision, but I do find the grey and blue colors very hard to tell apart.

I agree that with these dot sizes the colors do blend together especially when they're in close vicinity.

@cauemarcondes can we switch to use euiColorVis0 for the current series. I also ran this by a third party and I think we need to change the shape of the previous period even if we can't make it consistent in the legend. The value of having two different shapes to this type of comparison is too big not to do it. Sorry, I wasn't clearer before but I think it's the right thing to do. It doesn't have to match the styles I had in the design issue completely (different stroke color) but if we can use the square shape for the comparison, that'd be great!

Another small thing; the order of the series in the chart is reversed from all the other panels.

Screenshot 2021-04-21 at 09 42 04

@cauemarcondes
Copy link
Contributor Author

Screen Shot 2021-04-21 at 10 34 03

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.2MB 4.2MB +1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger added v7.14.0 and removed v7.13.0 labels Apr 21, 2021
@cauemarcondes cauemarcondes merged commit e76987e into elastic:master Apr 21, 2021
@cauemarcondes cauemarcondes deleted the apm-instance-chart-comparison branch April 21, 2021 20:47
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 21, 2021
@cauemarcondes @kibanamachine
[APM] add comparison to Instances latency distribution (elastic#97710)
658f35d 
* adding comparion data to chart

* fixing api test

* addressing comments

* refactoring
@kibanamachine kibanamachine mentioned this pull request Apr 21, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@cauemarcondes cauemarcondes mentioned this pull request Apr 21, 2021
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Apr 21, 2021
@cauemarcondes
[APM] add comparison to Instances latency distribution (elastic#97710)
946e11a 
* adding comparion data to chart

* fixing api test

* addressing comments

* refactoring
@cauemarcondes cauemarcondes mentioned this pull request Apr 21, 2021
Closed
kibanamachine added a commit that referenced this pull request Apr 21, 2021
@kibanamachine @cauemarcondes
[APM] add comparison to Instances latency distribution (#97710) (#97909)
955a5f8 
* adding comparion data to chart

* fixing api test

* addressing comments

* refactoring

Co-authored-by: Cauê Marcondes <[email protected]>
cauemarcondes added a commit that referenced this pull request Apr 22, 2021
@cauemarcondes @kibanamachine
[APM] add comparison to Instances latency distribution (#97710) (#97911)
ed6a860 
* adding comparion data to chart

* fixing api test

* addressing comments

* refactoring

Co-authored-by: Kibana Machine <[email protected]>
@ogupte ogupte self-assigned this May 10, 2021
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

Assignees

@ogupte ogupte

Labels
apm:comparison apm:test-plan-7.13.0 apm:test-plan-done Pull request that was successfully tested during the test plan auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.13.0 v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] add comparison to Instances latency distribution
7 participants
@cauemarcondes @elasticmachine @formgeist @kibanamachine @smith @spalger @ogupte