Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Compressed Spans #97438

Closed
wants to merge 1 commit into from
Closed

Implemented Compressed Spans #97438

wants to merge 1 commit into from

Conversation

AlexanderWert
Copy link
Member

@AlexanderWert AlexanderWert commented Apr 19, 2021 •
edited by sorenlouv
Loading

Summary

Implemented algorithm and UI for compressed spans:

image

@AlexanderWert AlexanderWert added the Team:APM All issues that need APM UI Team support label Apr 19, 2021
@AlexanderWert AlexanderWert requested a review from a team as a code owner April 19, 2021 10:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 19, 2021 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1575 1576 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.2MB 4.2MB +11.0KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cauemarcondes

@sorenlouv
Copy link
Member

This is awesome. Thanks @AlexanderWert!

cauemarcondes
cauemarcondes reviewed Apr 21, 2021
View reviewed changes
...omponents/app/transaction_details/WaterfallWithSummmary/WaterfallContainer/compress-spans.ts

const transformedItems: IWaterfallItem[] = [];

itemsToProcess.push(waterfall.entryWaterfallTransaction as IWaterfallItem);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it necessary to cast it to IWaterfallItem

@cauemarcondes cauemarcondes mentioned this pull request Jun 1, 2021
Closed
@AlexanderWert AlexanderWert mentioned this pull request Jul 27, 2021
Merged
9 tasks
@cauemarcondes
Copy link
Contributor

@AlexanderWert I think this PR can be closed, right?

@AlexanderWert
Copy link
Member Author

Resolved by #106862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes left review comments

Assignees

@cauemarcondes cauemarcondes

Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexanderWert @elasticmachine @kibanamachine @sorenlouv @cauemarcondes