-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time Series Metric Visualizations #9725
Conversation
@simianhacker When i tried to build on top of master from last night, I got the following optimization errors. Have you seen that? https://gist.github.com/tbragin/572ddac9e18340376e50e02e4e536621 |
Oops... forgot to add the flot-charts dependencies |
@simianhacker I got it built after the latest update, looking at it now :) |
One issue we must resolve right off the bat is one of naming. Right now in Visualize, all of the options aside from Timelion and this new Timeseries Metric vis are specific chart types. This is what the naming looks like in this WIP PR. My proposal is to:
Proposal 1. Discussed with @simianhacker originally. Proposal 2. The more I thought about it, using "Metrics" for this is ambiguous, as Timelion deals with metric data as well. The main difference between the Timelion approach vs this enhancement is expressions vs visual builder. @thomasneirynck @ppisljar @uboness @cjcenizal @alt74 @simianhacker @kimchy Thoughts? |
@simianhacker Does this visual builder support doing series ratio? So for instance ratio of errors to overall transactions, the equivalent of the following logic in Timelion: |
@tbragin For a series ratio's you are limited to |
@uboness and I chatted and discussed the naming - a couple of ideas there:
One thing I don't like right now is that descriptions push visualization types off page. Have we considered getting rid of them? Most people know what an area chart is - we don't need three lines of text explaining it. I personally prefer the simplified view without any descriptions because the chart types don't roll off the screen and Timelion and this new visual builder are a lot more discoverable as a result. @kimchy @simianhacker @alt74 @cjcenizal @ppisljar @thomasneirynck ^^ |
descriptions: i agree we don't need them .... but not seeing all the charts on one screen .... it really depends more on the number of charts and your screen resolution. What CJ is working on (removing open saved vis from this screen) is gonna solve this problem better. Probably we should put this (removing of description) in the CJs PR and not here. |
In a meeting room with Shay, Chris Cowan, JeffY, Michal, etc and we were going through the features we are highlighting for the Elasticon Keynote. The the naming scheme for some of the chart types in Visualize immediately struck us as a bit odd. 'Timeseries' as a single word is just not a word. It makes it seem like we are coming up with something special, which is not necessary here. Also preceding the two chart types with a colon also seems a little weird (I wonder if there's another way to let people know Timelion is for time series data through help text). A simple proposal is to just use the following for now: "Time series visual builder" |
…or Timelion and Time Series Visual Builder
@simianhacker I think I may have either ran into a bug or am misunderstanding the design. I'm looking at standard stock data from 2009 with other indices on my local kibana instance. Steps to reproduce:
However, if I select |
@alexfrancoeur Good catch... fixed |
Backports PR #9725 **Commit 1:** Initial import * Original sha: f9d527e * Authored by Chris Cowan <[email protected]> on 2016-12-21T00:27:11Z **Commit 2:** Merge branch 'master' of github.com:elastic/kibana into metrics * Original sha: c5e936f * Authored by Chris Cowan <[email protected]> on 2016-12-21T14:26:16Z **Commit 3:** updating the editor width to match the new specs * Original sha: 0d0f4c6 * Authored by Chris Cowan <[email protected]> on 2017-01-02T16:51:06Z **Commit 4:** Merge branch 'master' of github.com:elastic/kibana into metrics * Original sha: 2fb42d0 * Authored by Chris Cowan <[email protected]> on 2017-01-02T16:54:40Z **Commit 5:** Adding tribe node support * Original sha: 63a736a * Authored by Chris Cowan <[email protected]> on 2017-01-02T16:57:40Z **Commit 6:** Adding tests for server libs * Original sha: 6ede79b * Authored by Chris Cowan <[email protected]> on 2017-01-02T22:34:57Z **Commit 7:** removing bluebird * Original sha: 1cb2860 * Authored by Chris Cowan <[email protected]> on 2017-01-02T22:39:23Z **Commit 8:** removing extra cruft * Original sha: 4efe0ec * Authored by Chris Cowan <[email protected]> on 2017-01-04T17:01:32Z **Commit 9:** Fixing the font sizes * Original sha: 33f4d53 * Authored by Chris Cowan <[email protected]> on 2017-01-04T18:09:08Z **Commit 10:** Fixed the updating code * Original sha: 51ff9f8 * Authored by Chris Cowan <[email protected]> on 2017-01-04T18:56:29Z **Commit 11:** Adding brushing * Original sha: 2ba0463 * Authored by Chris Cowan <[email protected]> on 2017-01-04T20:23:46Z **Commit 12:** Fixing linting issues * Original sha: 09b6ada * Authored by Chris Cowan <[email protected]> on 2017-01-04T20:33:12Z **Commit 13:** Adding global filters * Original sha: 985ec1c * Authored by Chris Cowan <[email protected]> on 2017-01-04T21:44:20Z **Commit 14:** Adding missing packages * Original sha: bd87e89 * Authored by Chris Cowan <[email protected]> on 2017-01-05T13:16:15Z **Commit 15:** Default gauge style to half circle * Original sha: 5ce7d85 * Authored by Chris Cowan <[email protected]> on 2017-01-05T15:10:51Z **Commit 16:** Fixing the markdown css bug * Original sha: 0b72290 * Authored by Chris Cowan <[email protected]> on 2017-01-05T15:26:53Z **Commit 17:** Adding tests for the get_vis_data api * Original sha: a6e91ba * Authored by Chris Cowan <[email protected]> on 2017-01-12T15:16:05Z **Commit 18:** Adding time offset * Original sha: 5ee12ac * Authored by Chris Cowan <[email protected]> on 2017-01-12T17:36:56Z **Commit 19:** Adding time offset to each type * Original sha: ee52e34 * Authored by Chris Cowan <[email protected]> on 2017-01-12T17:42:33Z **Commit 20:** fixing bugs from time offset * Original sha: 16b7469 * Authored by Chris Cowan <[email protected]> on 2017-01-13T23:12:18Z **Commit 21:** adding index pattern option to series * Original sha: 1e64c7c * Authored by Chris Cowan <[email protected]> on 2017-01-17T21:57:13Z **Commit 22:** Merge branch 'master' of github.com:elastic/kibana into metrics * Original sha: b4ce642 * Authored by Chris Cowan <[email protected]> on 2017-01-17T23:05:40Z **Commit 23:** Adding index pattern overrides * Original sha: b5ff6c6 * Authored by Chris Cowan <[email protected]> on 2017-01-18T05:29:25Z **Commit 24:** Adding index pattern overrides * Original sha: 6641c8e * Authored by Chris Cowan <[email protected]> on 2017-01-18T05:38:12Z **Commit 25:** Fixing tests * Original sha: b7822ec * Authored by Chris Cowan <[email protected]> on 2017-01-18T05:43:56Z **Commit 26:** Fixing brushing in the vis editor * Original sha: 74dc57f * Authored by Chris Cowan <[email protected]> on 2017-01-18T17:14:04Z **Commit 27:** Changing the label * Original sha: 95e58b0 * Authored by Chris Cowan <[email protected]> on 2017-01-18T17:19:03Z **Commit 28:** Change the behavior of selecting a pipeline agg when only one exists. * Original sha: 5d2bf42 * Authored by Chris Cowan <[email protected]> on 2017-01-18T18:18:57Z **Commit 29:** Refactoring series a bit * Original sha: f1ff198 * Authored by Chris Cowan <[email protected]> on 2017-01-18T18:33:15Z **Commit 30:** Changing series options to just options * Original sha: 23821b5 * Authored by Chris Cowan <[email protected]> on 2017-01-18T20:34:59Z
Backports PR #9725 **Commit 1:** Initial import * Original sha: f9d527e * Authored by Chris Cowan <[email protected]> on 2016-12-21T00:27:11Z **Commit 2:** Merge branch 'master' of github.com:elastic/kibana into metrics * Original sha: c5e936f * Authored by Chris Cowan <[email protected]> on 2016-12-21T14:26:16Z **Commit 3:** updating the editor width to match the new specs * Original sha: 0d0f4c6 * Authored by Chris Cowan <[email protected]> on 2017-01-02T16:51:06Z **Commit 4:** Merge branch 'master' of github.com:elastic/kibana into metrics * Original sha: 2fb42d0 * Authored by Chris Cowan <[email protected]> on 2017-01-02T16:54:40Z **Commit 5:** Adding tribe node support * Original sha: 63a736a * Authored by Chris Cowan <[email protected]> on 2017-01-02T16:57:40Z **Commit 6:** Adding tests for server libs * Original sha: 6ede79b * Authored by Chris Cowan <[email protected]> on 2017-01-02T22:34:57Z **Commit 7:** removing bluebird * Original sha: 1cb2860 * Authored by Chris Cowan <[email protected]> on 2017-01-02T22:39:23Z **Commit 8:** removing extra cruft * Original sha: 4efe0ec * Authored by Chris Cowan <[email protected]> on 2017-01-04T17:01:32Z **Commit 9:** Fixing the font sizes * Original sha: 33f4d53 * Authored by Chris Cowan <[email protected]> on 2017-01-04T18:09:08Z **Commit 10:** Fixed the updating code * Original sha: 51ff9f8 * Authored by Chris Cowan <[email protected]> on 2017-01-04T18:56:29Z **Commit 11:** Adding brushing * Original sha: 2ba0463 * Authored by Chris Cowan <[email protected]> on 2017-01-04T20:23:46Z **Commit 12:** Fixing linting issues * Original sha: 09b6ada * Authored by Chris Cowan <[email protected]> on 2017-01-04T20:33:12Z **Commit 13:** Adding global filters * Original sha: 985ec1c * Authored by Chris Cowan <[email protected]> on 2017-01-04T21:44:20Z **Commit 14:** Adding missing packages * Original sha: bd87e89 * Authored by Chris Cowan <[email protected]> on 2017-01-05T13:16:15Z **Commit 15:** Default gauge style to half circle * Original sha: 5ce7d85 * Authored by Chris Cowan <[email protected]> on 2017-01-05T15:10:51Z **Commit 16:** Fixing the markdown css bug * Original sha: 0b72290 * Authored by Chris Cowan <[email protected]> on 2017-01-05T15:26:53Z **Commit 17:** Adding tests for the get_vis_data api * Original sha: a6e91ba * Authored by Chris Cowan <[email protected]> on 2017-01-12T15:16:05Z **Commit 18:** Adding time offset * Original sha: 5ee12ac * Authored by Chris Cowan <[email protected]> on 2017-01-12T17:36:56Z **Commit 19:** Adding time offset to each type * Original sha: ee52e34 * Authored by Chris Cowan <[email protected]> on 2017-01-12T17:42:33Z **Commit 20:** fixing bugs from time offset * Original sha: 16b7469 * Authored by Chris Cowan <[email protected]> on 2017-01-13T23:12:18Z **Commit 21:** adding index pattern option to series * Original sha: 1e64c7c * Authored by Chris Cowan <[email protected]> on 2017-01-17T21:57:13Z **Commit 22:** Merge branch 'master' of github.com:elastic/kibana into metrics * Original sha: b4ce642 * Authored by Chris Cowan <[email protected]> on 2017-01-17T23:05:40Z **Commit 23:** Adding index pattern overrides * Original sha: b5ff6c6 * Authored by Chris Cowan <[email protected]> on 2017-01-18T05:29:25Z **Commit 24:** Adding index pattern overrides * Original sha: 6641c8e * Authored by Chris Cowan <[email protected]> on 2017-01-18T05:38:12Z **Commit 25:** Fixing tests * Original sha: b7822ec * Authored by Chris Cowan <[email protected]> on 2017-01-18T05:43:56Z **Commit 26:** Fixing brushing in the vis editor * Original sha: 74dc57f * Authored by Chris Cowan <[email protected]> on 2017-01-18T17:14:04Z **Commit 27:** Changing the label * Original sha: 95e58b0 * Authored by Chris Cowan <[email protected]> on 2017-01-18T17:19:03Z **Commit 28:** Change the behavior of selecting a pipeline agg when only one exists. * Original sha: 5d2bf42 * Authored by Chris Cowan <[email protected]> on 2017-01-18T18:18:57Z **Commit 29:** Refactoring series a bit * Original sha: f1ff198 * Authored by Chris Cowan <[email protected]> on 2017-01-18T18:33:15Z **Commit 30:** Changing series options to just options * Original sha: 23821b5 * Authored by Chris Cowan <[email protected]> on 2017-01-18T20:34:59Z
// import AddDeleteButtons from '../add_delete_buttons'; | ||
// import Tooltip from '../tooltip'; | ||
|
||
// describe('<AddDeleteButtons />', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both giving LGTMs and merging while tests are commented out? -1 from me. I'm hoping there is an issue created already to fix this? If we can't get tests to run we have to either fix them or delete them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Oh, saw the comment in the backport. I still think this should have been fixed first though. Broken windows and all that.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your sentiment but we (team) wanted to get this commit in this week so it would be available via snapshots for Elastic{ON} and allow more time for people to use it before 5.4 ships. Luckily this is "soft"ware and we can work towards getting Enzyme working again. It broke when the Babel upgrade occurred; had this been merged before that upgrade it would hve been addressed by that team. The issue I have with keeping PR's like this separate for too long is you keep having to chase master as they change things; the PR keeps getting bigger and never seems to finish. With this merged we can now focus on creating smaller more manageable PR's to fix anything that needs addressed between now and code freeze.
Update: Issue created for bug tracking #10683
Date format is the following |
@jimgoodwin Summary & screenshots for 5.4 release blog Time Series Visual Builder provides a specialized user interface for users working with time series data. It allows users to build up analytics based on time-series in a visual way and uses pipeline aggregations in Elasticsearch to fully distribute all of the computation. While support for some of the pipeline aggregations is available in traditional Visualize charts, with Time Series Visual Builder we wanted to provide a curated experience focused specifically on working with time series data. Making the assumption around time-series simplifies the user interface and saves users many steps when building up these types of charts. Time Series Visual Builder also adds some unique features, such as confidence bands and annotations, specific to the time-series use case. Time Series Visual Builder is marked “experimental” in Kibana 5.4, which means that we may change or modify this feature in the future, and do not guarantee backward compatibility of charts built using this visualization type until it becomes available in GA. |
When using derivative with the network counters system.network.in.bytes / system.network.out.bytes when the incrementing counter resets I'm sometimes left with a rather large negative number, this usually occurs when the network is really busy thus increasing the value very quick. How do you deal with these negatives? |
@trevorndodds Add a "positive only" pipeline agg and set the derivative as the target metric |
Great thank you, I had to upgrade. |
This PR is for adding a new time series metrics editor and visualizations to Kibana. It supports the current set of pipeline aggregations and is gear towards time series data sets. It comes with 5 visualization types: Histogram, Gauge, Metric, Top N, and Markdown (with variable substitution).
Feature list: