[7.x] Use `EuiThemeProvider` in lists plugin tests and stories (#96129) #97027

kibanamachine · 2021-04-13T18:52:05Z

Backports the following commits to 7.x:

Use EuiThemeProvider in lists plugin tests and stories (Use EuiThemeProvider in lists plugin tests and stories #96129)

Remove `getMockTheme` and use `EuiThemeProvider` from the kibana_react plugin. Use the CSF-style decorators with `EuiThemeProvider` in the stories. No functional changes, but should be less code to maintain.

smith · 2021-04-13T20:13:56Z

@elasticmachine merge upstream

smith · 2021-04-15T21:03:13Z

@elasticmachine merge upstream

kibanamachine · 2021-04-15T23:14:56Z

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

API count

id	before	after	diff
`actions`	-	113	+113
`advancedSettings`	-	18	+18
`alerting`	-	200	+200
`apm`	-	35	+35
`apmOss`	-	38	+38
`banners`	-	9	+9
`beatsManagement`	-	2	+2
`bfetch`	-	58	+58
`canvas`	-	4	+4
`cases`	-	2	+2
`charts`	-	157	+157
`cloud`	-	19	+19
`console`	-	2	+2
`core`	-	2168	+2168
`dashboard`	-	138	+138
`dashboardEnhanced`	-	51	+51
`dashboardMode`	-	11	+11
`data`	-	3457	+3457
`dataEnhanced`	-	52	+52
`devTools`	-	9	+9
`discover`	-	61	+61
`discoverEnhanced`	-	39	+39
`embeddable`	-	426	+426
`embeddableEnhanced`	-	14	+14
`encryptedSavedObjects`	-	20	+20
`enterpriseSearch`	-	2	+2
`esUiShared`	-	84	+84
`eventLog`	-	70	+70
`expressions`	-	1755	+1755
`features`	-	199	+199
`fileUpload`	-	175	+175
`fleet`	-	1074	+1074
`globalSearch`	-	67	+67
`home`	-	91	+91
`indexLifecycleManagement`	-	5	+5
`indexManagement`	-	162	+162
`indexPatternFieldEditor`	-	29	+29
`indexPatternManagement`	-	46	+46
`infra`	-	14	+14
`ingestPipelines`	-	9	+9
`inspector`	-	97	+97
`kibanaLegacy`	-	92	+92
`kibanaReact`	-	232	+232
`kibanaUtils`	-	465	+465
`lens`	-	160	+160
`licenseManagement`	-	3	+3
`licensing`	-	116	+116
`lists`	-	251	+251
`management`	-	35	+35
`maps`	-	182	+182
`mapsEms`	-	69	+69
`ml`	-	343	+343
`monitoring`	-	9	+9
`navigation`	-	29	+29
`newsfeed`	-	17	+17
`observability`	-	157	+157
`osquery`	-	8	+8
`presentationUtil`	-	69	+69
`remoteClusters`	-	4	+4
`reporting`	-	118	+118
`rollup`	-	20	+20
`ruleRegistry`	-	19	+19
`runtimeFields`	-	22	+22
`savedObjects`	-	173	+173
`savedObjectsManagement`	-	91	+91
`savedObjectsTagging`	-	54	+54
`savedObjectsTaggingOss`	-	81	+81
`security`	-	79	+79
`securityOss`	-	11	+11
`securitySolution`	-	99	+99
`share`	-	66	+66
`snapshotRestore`	-	22	+22
`spaces`	-	82	+82
`spacesOss`	-	64	+64
`stackAlerts`	-	4	+4
`taskManager`	-	41	+41
`telemetry`	-	41	+41
`telemetryCollectionManager`	-	24	+24
`telemetryCollectionXpack`	-	1	+1
`telemetryManagementSection`	-	13	+13
`timelines`	-	6	+6
`triggersActionsUi`	-	221	+221
`uiActions`	-	127	+127
`uiActionsEnhanced`	-	185	+185
`uptime`	-	5	+5
`urlForwarding`	-	14	+14
`usageCollection`	-	53	+53
`visTypeTimeseries`	-	7	+7
`visualizations`	-	212	+212
total			+15178

API count missing comments

id	before	after	diff
`actions`	-	113	+113
`advancedSettings`	-	17	+17
`alerting`	-	200	+200
`apm`	-	35	+35
`apmOss`	-	38	+38
`banners`	-	9	+9
`beatsManagement`	-	2	+2
`bfetch`	-	47	+47
`canvas`	-	3	+3
`cases`	-	2	+2
`charts`	-	132	+132
`cloud`	-	19	+19
`console`	-	2	+2
`core`	-	989	+989
`dashboard`	-	126	+126
`dashboardEnhanced`	-	50	+50
`dashboardMode`	-	11	+11
`data`	-	2965	+2965
`dataEnhanced`	-	34	+34
`devTools`	-	8	+8
`discover`	-	48	+48
`discoverEnhanced`	-	37	+37
`embeddable`	-	361	+361
`embeddableEnhanced`	-	14	+14
`encryptedSavedObjects`	-	18	+18
`enterpriseSearch`	-	2	+2
`esUiShared`	-	82	+82
`eventLog`	-	70	+70
`expressions`	-	1364	+1364
`features`	-	89	+89
`fileUpload`	-	175	+175
`fleet`	-	984	+984
`globalSearch`	-	13	+13
`home`	-	67	+67
`indexLifecycleManagement`	-	5	+5
`indexManagement`	-	157	+157
`indexPatternFieldEditor`	-	27	+27
`indexPatternManagement`	-	46	+46
`infra`	-	11	+11
`ingestPipelines`	-	9	+9
`inspector`	-	77	+77
`kibanaLegacy`	-	84	+84
`kibanaReact`	-	207	+207
`kibanaUtils`	-	301	+301
`lens`	-	149	+149
`licenseManagement`	-	3	+3
`licensing`	-	40	+40
`lists`	-	234	+234
`management`	-	35	+35
`maps`	-	181	+181
`mapsEms`	-	69	+69
`ml`	-	339	+339
`monitoring`	-	9	+9
`navigation`	-	29	+29
`newsfeed`	-	17	+17
`observability`	-	157	+157
`osquery`	-	8	+8
`presentationUtil`	-	67	+67
`remoteClusters`	-	4	+4
`reporting`	-	117	+117
`rollup`	-	20	+20
`ruleRegistry`	-	19	+19
`runtimeFields`	-	17	+17
`savedObjects`	-	159	+159
`savedObjectsManagement`	-	80	+80
`savedObjectsTagging`	-	50	+50
`savedObjectsTaggingOss`	-	42	+42
`security`	-	38	+38
`securityOss`	-	8	+8
`securitySolution`	-	90	+90
`share`	-	60	+60
`snapshotRestore`	-	22	+22
`spaces`	-	65	+65
`spacesOss`	-	29	+29
`stackAlerts`	-	4	+4
`taskManager`	-	16	+16
`telemetry`	-	37	+37
`telemetryCollectionManager`	-	24	+24
`telemetryCollectionXpack`	-	1	+1
`telemetryManagementSection`	-	12	+12
`timelines`	-	6	+6
`triggersActionsUi`	-	212	+212
`uiActions`	-	88	+88
`uiActionsEnhanced`	-	135	+135
`uptime`	-	5	+5
`urlForwarding`	-	14	+14
`usageCollection`	-	46	+46
`visTypeTimeseries`	-	7	+7
`visualizations`	-	194	+194
total			+12008

API count with any type

id	before	after	diff
`bfetch`	-	1	+1
`charts`	-	2	+2
`core`	-	147	+147
`dashboard`	-	1	+1
`data`	-	81	+81
`embeddable`	-	2	+2
`esUiShared`	-	4	+4
`expressions`	-	44	+44
`fileUpload`	-	6	+6
`fleet`	-	16	+16
`indexManagement`	-	12	+12
`inspector`	-	6	+6
`kibanaLegacy`	-	3	+3
`kibanaUtils`	-	3	+3
`maps`	-	2	+2
`mapsEms`	-	1	+1
`ml`	-	14	+14
`reporting`	-	1	+1
`savedObjects`	-	3	+3
`share`	-	1	+1
`snapshotRestore`	-	1	+1
`triggersActionsUi`	-	1	+1
`visualizations`	-	11	+11
total			+363

Non-exported public API item count

id	before	after	diff
`actions`	-	6	+6
`advancedSettings`	-	1	+1
`alerting`	-	9	+9
`apm`	-	8	+8
`bfetch`	-	2	+2
`canvas`	-	2	+2
`cases`	-	1	+1
`charts`	-	2	+2
`core`	-	29	+29
`dashboard`	-	9	+9
`data`	-	75	+75
`dataEnhanced`	-	2	+2
`devTools`	-	2	+2
`discover`	-	6	+6
`discoverEnhanced`	-	2	+2
`embeddable`	-	3	+3
`encryptedSavedObjects`	-	4	+4
`esUiShared`	-	4	+4
`eventLog`	-	4	+4
`expressions`	-	7	+7
`features`	-	1	+1
`fleet`	-	10	+10
`globalSearch`	-	6	+6
`home`	-	8	+8
`indexManagement`	-	4	+4
`indexPatternFieldEditor`	-	4	+4
`indexPatternManagement`	-	4	+4
`infra`	-	2	+2
`ingestPipelines`	-	4	+4
`inspector`	-	4	+4
`kibanaLegacy`	-	1	+1
`kibanaReact`	-	3	+3
`kibanaUtils`	-	8	+8
`lens`	-	12	+12
`licensing`	-	10	+10
`lists`	-	60	+60
`management`	-	4	+4
`maps`	-	16	+16
`ml`	-	34	+34
`navigation`	-	3	+3
`observability`	-	8	+8
`presentationUtil`	-	4	+4
`reporting`	-	17	+17
`ruleRegistry`	-	3	+3
`runtimeFields`	-	2	+2
`savedObjects`	-	5	+5
`savedObjectsManagement`	-	1	+1
`security`	-	10	+10
`securityOss`	-	3	+3
`securitySolution`	-	7	+7
`share`	-	3	+3
`snapshotRestore`	-	1	+1
`spaces`	-	3	+3
`taskManager`	-	3	+3
`telemetry`	-	3	+3
`telemetryCollectionManager`	-	4	+4
`timelines`	-	1	+1
`triggersActionsUi`	-	28	+28
`uiActions`	-	9	+9
`uiActionsEnhanced`	-	10	+10
`uptime`	-	3	+3
`usageCollection`	-	7	+7
`visTypeTimeseries`	-	2	+2
`visualizations`	-	6	+6
total			+519

History

💔 Build #119360 failed ac5247c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @smith

Use EuiThemeProvider in lists plugin tests and stories (elastic#96129)

ac5247c

Remove `getMockTheme` and use `EuiThemeProvider` from the kibana_react plugin. Use the CSF-style decorators with `EuiThemeProvider` in the stories. No functional changes, but should be less code to maintain.

kibanamachine assigned smith Apr 13, 2021

kibanamachine added the backport label Apr 13, 2021

kibanamachine enabled auto-merge (squash) April 13, 2021 18:52

kibanamachine mentioned this pull request Apr 13, 2021

Use EuiThemeProvider in lists plugin tests and stories #96129

Merged

Merge branch '7.x' into backport/7.x/pr-96129

51101bc

Merge branch '7.x' into backport/7.x/pr-96129

95b6ba2

kibanamachine merged commit 64d0df6 into elastic:7.x Apr 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[7.x] Use `EuiThemeProvider` in lists plugin tests and stories (#96129) #97027

[7.x] Use `EuiThemeProvider` in lists plugin tests and stories (#96129) #97027

kibanamachine commented Apr 13, 2021

smith commented Apr 13, 2021

smith commented Apr 15, 2021

kibanamachine commented Apr 15, 2021

API count

API count missing comments

API count with any type

Non-exported public API item count

[7.x] Use EuiThemeProvider in lists plugin tests and stories (#96129) #97027

[7.x] Use EuiThemeProvider in lists plugin tests and stories (#96129) #97027

Conversation

kibanamachine commented Apr 13, 2021

smith commented Apr 13, 2021

smith commented Apr 15, 2021

kibanamachine commented Apr 15, 2021

💚 Build Succeeded

Metrics [docs]

API count

API count missing comments

API count with any type

Non-exported public API item count

History

[7.x] Use `EuiThemeProvider` in lists plugin tests and stories (#96129) #97027

[7.x] Use `EuiThemeProvider` in lists plugin tests and stories (#96129) #97027