babel 6 upgrade #9702

coverslide · 2017-01-03T09:18:21Z

Note this is mostly piggybacking off of @spalger 's work on PR #7010 in reference to issue #5822

I rebased that branch onto master and made the necessary changes to get it working properly.

Some notes on the changes:

Use babel plugins and presets instead of a list of specific settings
The "export default" problem has been fixed by adding the "add-module-exports" plugin. This allows us to mix require() statements with es6 modules without having to modify anything.
The "es2015-node" preset solves the issue of separating node-specific transforms and browser-specific transforms. It also feature-detects based on the running version of node.
The "class-properties" plugin seems to need loading before the presets so that was added to the plugins list.

This PR has been linted and tested from the latest master.

elasticmachine · 2017-01-03T09:18:23Z

Can one of the admins verify this patch?

spalger · 2017-01-03T16:40:37Z

Thanks @coverslide! I'll take a look at this soon

coverslide · 2017-01-04T16:59:52Z

@spalger rebased to fix a conflict

spalger · 2017-01-07T00:12:49Z

jenkins, test this

coverslide · 2017-01-13T22:01:58Z

@spalger made a few fixes, I ran locally and fails 1 selenium test, but that same test was failing on master so it may just be my machine, could we re-run jenkins on this?

coverslide · 2017-01-21T06:57:06Z

@spalger I found the issue, and now all tests pass for me! Could we check this again? Sorry, hopefully third time is the charm!

It looks like the way we require ui/notifier from kbn_chrome.js still has the require(...).default bug, but I don't see the issue anywhere else.

coverslide · 2017-01-25T23:38:22Z

@spalger fixed a merge conflict, any chance we can re-check this?

coverslide · 2017-01-27T18:56:43Z

@epixa I see the tests passed here: https://kibana-ci.elastic.co/job/elastic-kibana-pull-request/3668/ but the kibana-ci check didn't update. I think I pushed up the latest update after the check had already started. There will be no more pushes.

epixa · 2017-01-27T19:11:08Z

jenkins, test this

coverslide · 2017-02-01T21:57:15Z

@spalger @epixa Any movement on this?

[babel] Use WIP babel-6-fix branch of babel-preset-kibana

…ibility

coverslide · 2017-02-07T01:18:27Z

@spalger awesome. I noticed one of the scripts did not run properly when tested. Looking into it.

…el6-update-2

spalger · 2017-02-07T19:43:08Z

jenkins, test this

spalger

LGTM

jbudz · 2017-02-08T16:22:22Z

src/optimize/babel/helpers.js

+}
+
+if (!env.WEBPACK_BABEL_CACHE_DIR) {
+  env.WEBPACK_BABEL_CACHE_DIR = fromRoot('optimize/.webpack.babelcache');


this file doesn't seem to be generating, if it's supposed to be can we add it here to play nice with package permissions

Good catch, I enabled it in dev, but it's disabled in the distributable because it creates a directory and we won't be able to ensure all of it's files are chowned

jbudz · 2017-02-09T15:29:18Z

LGTM for core, can we make sure plugins are updated too?

…el6-update-2

* [npm] upgrade babel The upgrade to babel 6 requires an upgrade to all of the associated modules, which meant that a few other things changed at the same time. The most notable is the way that we handle our babel-options, which is now done with an npm module and includes using the babel-loader's "presets" query string param. This meant changes to the babel_options.js module and extending it to help setting up the "babel-register" module, which was previously copy-pasted in several places. * [mtodules] upgrade to support babel6 module semantics * [eslint] fix lint errors * [babel] ignoer massive fixture files * [cli/errors] use Object.setPrototypeOf since subclassing Error is broken * [babel] Upgrading core babel libraries [babel] Use WIP babel-6-fix branch of babel-preset-kibana * Fix broken test * [babel] Reverse unnecessary module.exports changes * Fix notifier * Use babel presets and plugins directly * [babel/options] resolve preset/plugins paths for better plugin compatibility * [babel/options] use babel-preset-env for correct node settings * [babel] cache babel compilation in webpack like we thought we were

coverslide force-pushed the implement/babel6-update-2 branch 3 times, most recently from d1e8cf8 to d9a0628 Compare January 3, 2017 10:09

spalger self-assigned this Jan 3, 2017

spalger added review v6.0.0 labels Jan 3, 2017

spalger added the v5.2.0 label Jan 3, 2017

coverslide force-pushed the implement/babel6-update-2 branch 2 times, most recently from ed1bf96 to b5bbc34 Compare January 4, 2017 16:59

coverslide force-pushed the implement/babel6-update-2 branch 4 times, most recently from 2ec807e to b04c97b Compare January 12, 2017 07:36

epixa removed the v5.2.0 label Jan 17, 2017

coverslide force-pushed the implement/babel6-update-2 branch from 3b3e518 to 017e731 Compare January 21, 2017 06:52

coverslide force-pushed the implement/babel6-update-2 branch 3 times, most recently from 9732765 to 4544a20 Compare January 25, 2017 21:49

coverslide force-pushed the implement/babel6-update-2 branch from 4544a20 to 0eebcb5 Compare January 27, 2017 18:23

spalger added the Team:Operations Team label for Operations Team label Feb 6, 2017

spalger and others added 10 commits February 6, 2017 15:47

[mtodules] upgrade to support babel6 module semantics

fa94417

[eslint] fix lint errors

071db84

[babel] ignoer massive fixture files

6c7ec96

[cli/errors] use Object.setPrototypeOf since subclassing Error is broken

8befb13

[babel] Upgrading core babel libraries

f0afbcd

[babel] Use WIP babel-6-fix branch of babel-preset-kibana

Fix broken test

0a563c8

[babel] Reverse unnecessary module.exports changes

ebc2bab

Fix notifier

7ebbfc6

Use babel presets and plugins directly

2aee1aa

[babel/options] resolve preset/plugins paths for better plugin compat…

94c2054

…ibility

coverslide force-pushed the implement/babel6-update-2 branch from bf49ac6 to 94c2054 Compare February 6, 2017 23:48

spalger added 2 commits February 6, 2017 21:49

[babel/options] use babel-preset-env for correct node settings

65458ca

Merge branch 'master' of github.com:elastic/kibana into implement/bab…

5713716

…el6-update-2

spalger requested review from tylersmalley and jbudz February 7, 2017 21:31

spalger approved these changes Feb 7, 2017

View reviewed changes

spalger removed the request for review from tylersmalley February 7, 2017 21:31

jbudz requested changes Feb 8, 2017

View reviewed changes

[babel] cache babel compilation in webpack like we thought we were

de9e157

jbudz approved these changes Feb 9, 2017

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into implement/bab…

cd73ab4

…el6-update-2

spalger merged commit 8b4c052 into elastic:master Feb 9, 2017

spalger mentioned this pull request Feb 9, 2017

[5.x] babel 6 upgrade #10278

Merged

spalger added the v5.4.0 label Feb 9, 2017

spalger mentioned this pull request Feb 28, 2017

upgrade to babel 6 #5822

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

babel 6 upgrade #9702

babel 6 upgrade #9702

coverslide commented Jan 3, 2017 •

edited

Loading

elasticmachine commented Jan 3, 2017

spalger commented Jan 3, 2017

coverslide commented Jan 4, 2017

spalger commented Jan 7, 2017

coverslide commented Jan 13, 2017

coverslide commented Jan 21, 2017 •

edited

Loading

coverslide commented Jan 25, 2017

coverslide commented Jan 27, 2017

epixa commented Jan 27, 2017

coverslide commented Feb 1, 2017

coverslide commented Feb 7, 2017

spalger commented Feb 7, 2017

spalger left a comment

jbudz Feb 8, 2017

spalger Feb 8, 2017

jbudz commented Feb 9, 2017

babel 6 upgrade #9702

babel 6 upgrade #9702

Conversation

coverslide commented Jan 3, 2017 • edited Loading

elasticmachine commented Jan 3, 2017

spalger commented Jan 3, 2017

coverslide commented Jan 4, 2017

spalger commented Jan 7, 2017

coverslide commented Jan 13, 2017

coverslide commented Jan 21, 2017 • edited Loading

coverslide commented Jan 25, 2017

coverslide commented Jan 27, 2017

epixa commented Jan 27, 2017

coverslide commented Feb 1, 2017

coverslide commented Feb 7, 2017

spalger commented Feb 7, 2017

spalger left a comment

Choose a reason for hiding this comment

jbudz Feb 8, 2017

Choose a reason for hiding this comment

spalger Feb 8, 2017

Choose a reason for hiding this comment

jbudz commented Feb 9, 2017

coverslide commented Jan 3, 2017 •

edited

Loading

coverslide commented Jan 21, 2017 •

edited

Loading