Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Enable brush for visualizations created with no index patterns #96727

Merged
merged 3 commits into from
Apr 14, 2021
Merged

[TSVB] Enable brush for visualizations created with no index patterns #96727

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb26c18
[TSVB] Enable brush for visualizations created with no index patterns
stratoula Apr 12, 2021
6f883f2
Fix comments typo
stratoula Apr 12, 2021
2eeb05d
Merge branch 'master' into drilldowns-no-index-pattern
kibanamachine Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 37 additions & 15 deletions src/plugins/vis_type_timeseries/public/application/components/timeseries_visualization.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,22 +59,44 @@ function TimeseriesVisualization({
const indexPatternValue = model.index_pattern || '';
const { indexPatterns } = getDataStart();
const { indexPattern } = await fetchIndexPattern(indexPatternValue, indexPatterns);
let event;
// trigger applyFilter if no index pattern found, url drilldowns are supported only
// for the index pattern mode
if (indexPattern) {
const tables = indexPattern
? await convertSeriesToDataTable(model, series, indexPattern)
: null;
const table = tables?.[model.series[0].id];

const range: [number, number] = [parseInt(gte, 10), parseInt(lte, 10)];
event = {
data: {
table,
column: X_ACCESSOR_INDEX,
range,
timeFieldName: indexPattern?.timeFieldName,
},
name: 'brush',
};
} else {
event = {
name: 'applyFilter',
data: {
timeFieldName: '*',
filters: [
{
range: {
'*': {
gte,
lte,
},
},
},
],
},
};
}

const tables = indexPattern
? await convertSeriesToDataTable(model, series, indexPattern)
: null;
const table = tables?.[model.series[0].id];

const range: [number, number] = [parseInt(gte, 10), parseInt(lte, 10)];
const event = {
data: {
table,
column: X_ACCESSOR_INDEX,
range,
timeFieldName: indexPattern?.timeFieldName,
},
name: 'brush',
};
handlers.event(event);
},
[handlers, model]
Expand Down