Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Search Polish #96345

Merged
merged 4 commits into from
Apr 7, 2021
Merged

App Search Polish #96345

merged 4 commits into from
Apr 7, 2021

Conversation

daveyholler
Copy link
Contributor

Summary

I'm gonna try to tackle these polish items in the smallest PRs possible.

Screenshot from 2021-04-06 11-08-47

Screenshot from 2021-04-06 11-09-26

  • Updates the buttons on the Engine Overview Page
  • Aligns the headings on the Relevance Tuning Page
  • Changes the preview panel to a subdued panel

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@daveyholler daveyholler added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 6, 2021
@daveyholler daveyholler requested review from cee-chen, JasonStoltz and a team April 6, 2021 19:02
@cee-chen
Copy link
Contributor

cee-chen commented Apr 7, 2021

@elasticmachine merge upstream

Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super appreciate the atomic PRs Davey!! You rock!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.9MB 1.9MB +245.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@daveyholler daveyholler merged commit 8e1bd9c into elastic:master Apr 7, 2021
daveyholler added a commit to daveyholler/kibana that referenced this pull request Apr 8, 2021
* Button adjustments to Engine Overview page

* Subdued preview panel color

* Vertically aligns "manage fields" and "preview"

Co-authored-by: Kibana Machine <[email protected]>
daveyholler added a commit that referenced this pull request Apr 8, 2021
* Button adjustments to Engine Overview page

* Subdued preview panel color

* Vertically aligns "manage fields" and "preview"

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@cee-chen cee-chen mentioned this pull request Apr 12, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants