-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migration v2 respects the config.batchSize value #96207
Merged
mshustov
merged 7 commits into
elastic:master
from
mshustov:issue-93155-migrations-batchSize
Apr 6, 2021
Merged
migration v2 respects the config.batchSize value #96207
mshustov
merged 7 commits into
elastic:master
from
mshustov:issue-93155-migrations-batchSize
Apr 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.13.0
labels
Apr 5, 2021
mshustov
added
the
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
label
Apr 6, 2021
Pinging @elastic/kibana-core (Team:Core) |
pgayvallet
approved these changes
Apr 6, 2021
mshustov
added
the
auto-backport
Deprecated - use backport:version if exact versions are needed
label
Apr 6, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 Backport failed❌ 7.x: Commit could not be cherrypicked due to conflicts To backport manually run: |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Apr 6, 2021
* migrationsv2: read batchSize from config * update tests * update numeric values in so config to improve reading * fix integration tests. failed with illegal_argument_exception
mshustov
added a commit
that referenced
this pull request
Apr 6, 2021
* migrationsv2: read batchSize from config * update tests * update numeric values in so config to improve reading * fix integration tests. failed with illegal_argument_exception Co-authored-by: Kibana Machine <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.13.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parent issue #93155
Migration v2 algorithm should respect
config.batchSize
value when fetching SO from ES to run migration for them.I'm going to add docs in a follow-up PR.