Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration v2 respects the config.batchSize value #96207

Merged
merged 7 commits into from
Apr 6, 2021

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Apr 5, 2021

Summary

Parent issue #93155
Migration v2 algorithm should respect config.batchSize value when fetching SO from ES to run migration for them.
I'm going to add docs in a follow-up PR.

@mshustov mshustov added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 5, 2021
@mshustov mshustov requested a review from rudolf April 5, 2021 11:05
@mshustov mshustov marked this pull request as ready for review April 5, 2021 11:28
@mshustov mshustov requested a review from a team as a code owner April 5, 2021 11:28
@mshustov mshustov added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Apr 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@mshustov mshustov enabled auto-merge (squash) April 6, 2021 09:21
@mshustov mshustov added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 6, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 157129e into elastic:master Apr 6, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

❌ 7.x: Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 96207

@mshustov mshustov deleted the issue-93155-migrations-batchSize branch April 6, 2021 12:56
mshustov added a commit to mshustov/kibana that referenced this pull request Apr 6, 2021
* migrationsv2: read batchSize from config

* update tests

* update numeric values in so config to improve reading

* fix integration tests. failed with illegal_argument_exception
mshustov added a commit that referenced this pull request Apr 6, 2021
* migrationsv2: read batchSize from config

* update tests

* update numeric values in so config to improve reading

* fix integration tests. failed with illegal_argument_exception

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants