-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search Sessions] fix updating deleting sessions from non-default space #96123
[Search Sessions] fix updating deleting sessions from non-default space #96123
Conversation
Pinging @elastic/kibana-app-services (Team:AppServices) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to the logic LGTM
Can we update the unit tests in x-pack/plugins/data_enhanced/server/search/session/check_running_sessions.test.ts
to verify that we're calling the Saved Objects Client with the appropriate namespace
for the update
and delete
operations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…ce (elastic#96123) * add spaces test * fix updating and deleting sessions in non-default space * revert back to batch update * Add space tests Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Liza K <[email protected]>
…ce (elastic#96123) * add spaces test * fix updating and deleting sessions in non-default space * revert back to batch update * Add space tests Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Liza K <[email protected]> # Conflicts: # x-pack/plugins/data_enhanced/server/search/session/check_running_sessions.ts
…ce (#96123) (#96210) * add spaces test * fix updating and deleting sessions in non-default space * revert back to batch update * Add space tests Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Liza K <[email protected]> Co-authored-by: Anton Dosov <[email protected]> Co-authored-by: Liza K <[email protected]>
…ce (#96123) (#96211) * add spaces test * fix updating and deleting sessions in non-default space * revert back to batch update * Add space tests Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Liza K <[email protected]> # Conflicts: # x-pack/plugins/data_enhanced/server/search/session/check_running_sessions.ts Co-authored-by: Anton Dosov <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
…lastic#99617) Co-authored-by: Kaarina Tungseth <[email protected]>
…#99965) Co-authored-by: Kaarina Tungseth <[email protected]>
Summary
Potential bare minimum fix for #96124
The problem was that updates/deletes of sessions from non-default spaces failed with
404
because we were trying to update/delete them in the default space.I also improved logging a bit.
While debugging we identify other potential improvements, but they out of scope for this patch pr: #96131
Checklist
Delete any items that are not applicable to this PR.
For maintainers