Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/optimizer] import source-map-support in script to avoid breaking jest snapshots #96011

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Apr 1, 2021

Due to a recent change in Jest importing source-map-support/register within a worker breaks inline snapshots. Moving the import to the script allows jest -u to update inline snapshots again!

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 1, 2021
@spalger spalger requested a review from tylersmalley April 1, 2021 01:27
@spalger spalger requested a review from a team as a code owner April 1, 2021 01:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger changed the title [kbn/optimizer] import source-map-support in script to avoid breaking… [kbn/optimizer] import source-map-support in script to avoid breaking jest snapshots Apr 1, 2021
@spalger spalger merged commit 07a3f9e into elastic:master Apr 1, 2021
@spalger spalger deleted the fix/jest-inline-snapshots branch April 1, 2021 01:36
@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 1, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 1, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #96013

This backport PR will be merged automatically after passing CI.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine added a commit that referenced this pull request Apr 1, 2021
… jest snapshots (#96011) (#96013)

Co-authored-by: spalger <[email protected]>

Co-authored-by: Spencer <[email protected]>
Co-authored-by: spalger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants