[Rollup] Migrate to new ES client #95926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
v8.0.0
Team:Kibana Management
74 tasks
17 tasks
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
yuliacech
reviewed
Apr 7, 2021
| indexPattern: '_all', | ||
| } | ||
| ); | ||
| const { client: clusterClient } = context.core.elasticsearch; |
There was a problem hiding this comment.
nit: not sure why we need to rename client here.
yuliacech
reviewed
Apr 7, 2021
| @@ -71,16 +67,12 @@ export const registerValidateIndexPatternRoute = ({ | |||
| }, | |||
| }, | |||
| license.guardApiRoute(async (context, request, response) => { | |||
| const { client: clusterClient } = context.core.elasticsearch; | |||
yuliacech
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Hi @jloleysens, thanks a lot for migrating rollup jobs to the new client!
I tested locally and everything worked for me. Code changes LGTM too, just left one nit in the comments about renaming when object destructuring.
This was referenced Apr 7, 2021
jloleysens
added a commit
that referenced
this pull request
Apr 8, 2021
* initial pass at es client migration * fixed potential for not passing in an error message and triggering an unhandled exception * reworked ad hoc fixing of error response * delete legacy client file and remove use of legacyEs service * remove unused import Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/rollup/server/routes/api/jobs/register_start_route.ts Co-authored-by: Kibana Machine <[email protected]>
alisonelizabeth
added
Feature:Rollups
and removed
Feature:Snapshot and Restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #73973
How to test