Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autocomplete telemetry #95724

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Fix autocomplete telemetry #95724

merged 2 commits into from
Apr 2, 2021

Conversation

lukasolson
Copy link
Member

Summary

Because of the way that telemetry data for UI metrics is summarized before being shipped off, the data we're collecting for autocomplete is inaccurate.

For example, if a user selects the suggestion in position 5, then position 6, the value reported will actually be 11 (instead of an average).

This PR adjusts the way we collect to report different keys (e.g. query_string:value:suggestions_select_position_5). This was the recommendation from the telemetry folks. When analyzing, we can sort by the sum and see which position is selected most frequently, however this will make it difficult to get a single value that summarizes the average position selected.

@lukasolson lukasolson requested review from lizozom and Dosant March 29, 2021 22:07
@lukasolson lukasolson self-assigned this Mar 29, 2021
@lukasolson lukasolson requested a review from a team as a code owner March 29, 2021 22:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@lukasolson lukasolson force-pushed the fix/autocomplete-telemetry branch from 23f64bf to 0ad8f36 Compare March 29, 2021 22:59
lizozom
lizozom reviewed Mar 30, 2021
View reviewed changes
src/plugins/data/public/ui/query_string_input/query_string_input.tsx
`query_string:${type}:suggestions_select_position`,
listIndex
METRIC_TYPE.CLICK,
`query_string:${type}:suggestions_select_position_${listIndex}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a way to report this without losing the numeric nature of the data?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😕 Not using UI metrics. If we wanted to introduce our own mechanism for collecting/reporting data, we could probably get around it, but I'm not sure it's worth the effort. We can still do side-by-side comparisons of the different autocomplete implementations, we just won't have a single metric to compare side-by-side. (Although we may be able to get around this by using a scripted field...)

lizozom
lizozom approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal, but best solution ATM 🤷🏻 😄

@lukasolson
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
data 176.1KB 176.1KB +4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

@lukasolson lukasolson merged commit 59100b5 into elastic:master Apr 2, 2021
@lukasolson lukasolson mentioned this pull request Apr 5, 2021
Merged
lukasolson added a commit to lukasolson/kibana that referenced this pull request Apr 5, 2021
@lukasolson @kibanamachine
Fix autocomplete telemetry (elastic#95724)
bfdaa90 
Co-authored-by: Kibana Machine <[email protected]>
@lukasolson lukasolson mentioned this pull request Apr 5, 2021
Merged
lukasolson added a commit to lukasolson/kibana that referenced this pull request Apr 5, 2021
@lukasolson @kibanamachine
Fix autocomplete telemetry (elastic#95724)
2f314c5 
Co-authored-by: Kibana Machine <[email protected]>
lukasolson added a commit that referenced this pull request Apr 5, 2021
@lukasolson @kibanamachine
Fix autocomplete telemetry (#95724) (#96219)
34441e6 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 6, 2021
lukasolson added a commit that referenced this pull request Apr 6, 2021
@lukasolson @kibanamachine
Fix autocomplete telemetry (#95724) (#96218)
2ebcddb 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizozom lizozom lizozom approved these changes

@Dosant Dosant Awaiting requested review from Dosant

Assignees

@lukasolson lukasolson

Labels
Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes review v7.12.1 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukasolson @elasticmachine @kibanamachine @lizozom