Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Change layout of top values function #95412

Merged
merged 1 commit into from
Mar 26, 2021
Merged

[Lens] Change layout of top values function #95412

merged 1 commit into from
Mar 26, 2021

Conversation

flash1293
Copy link
Contributor

Fixes #93912

This rearranges the layout of the top values function in two ways:

  • Remove the slider for number of top values
  • Change the "advanced" popover into an accordion

As a band-aid fix for the limit of top values (#95007), this PR is also increasing the maximum number of terms to 1000

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 25, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 903.2KB 903.0KB -246.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review March 25, 2021 16:08
@flash1293 flash1293 requested a review from a team March 25, 2021 16:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

wylieconlon
wylieconlon approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, here's a screenshot:

Screen Shot 2021-03-25 at 3 56 41 PM

@flash1293 flash1293 merged commit b7d84ab into elastic:master Mar 26, 2021
@kibanamachine kibanamachine mentioned this pull request Mar 26, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 26, 2021
@flash1293 @kibanamachine
change layout of top values function (elastic#95412)
1e65c54
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #95546

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 26, 2021
@kibanamachine @flash1293
change layout of top values function (#95412) (#95546)
394d674 
Co-authored-by: Joe Reuter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wylieconlon wylieconlon wylieconlon approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Restructure top values dimension editor
4 participants
@flash1293 @kibanamachine @elasticmachine @wylieconlon