Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CIT test for the fail processor. #95261

Merged
merged 10 commits into from
May 11, 2021
Merged

Added CIT test for the fail processor. #95261

merged 10 commits into from
May 11, 2021

Conversation

cuff-links
Copy link
Contributor

Summary

This PR is to add test coverage for the Ingest Pipelines Fail Processor.

Test cases being covered

  1. Prevents submission 0/1 required fields given.
  2. Saves processor with default options
  3. Saves processor with setting optional options.

@cuff-links cuff-links added test-jest-integration v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Ingest Node Pipelines Ingest node pipelines management v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.12.1 labels Mar 24, 2021
@cuff-links cuff-links marked this pull request as ready for review March 24, 2021 15:11
@cuff-links cuff-links requested a review from a team as a code owner March 24, 2021 15:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cuff-links cuff-links added the release_note:skip Skip the PR/issue when compiling release notes label Mar 24, 2021
jloleysens
jloleysens reviewed Mar 25, 2021
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this test @cuff-links !

I left a comment that I think we should resolve before creating more tests.

...st_pipelines/public/application/components/pipeline_editor/__jest__/processors/fail.test.tsx Outdated Show resolved Hide resolved
@cuff-links cuff-links mentioned this pull request Mar 25, 2021
Closed
10 tasks
@cuff-links
Copy link
Contributor Author

#95001 being merged will fix this error.

alisonelizabeth
alisonelizabeth approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @cuff-links! I left a few comments in the code if you don't mind taking a look, but not worth blocking on.

.../application/components/pipeline_editor/__jest__/processors/common_processor_fields.test.tsx Show resolved Hide resolved
...st_pipelines/public/application/components/pipeline_editor/__jest__/processors/fail.test.tsx Show resolved Hide resolved
...st_pipelines/public/application/components/pipeline_editor/__jest__/processors/fail.test.tsx Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 680.6KB 680.7KB +32.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 4 2 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 5 3 -2
licensing 18 15 -3
monitoring 109 56 -53
total -73

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cuff-links cuff-links merged commit dc8329e into elastic:master May 11, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 11, 2021
@kibanamachine
Added CIT test for the fail processor. (elastic#95261)
d310a23 
* Added CIT test for the fail processor.

* Fixed linter issues.

* Used new functions and helpers.

* Added common test to ensure that a processor type was selected before saving. Fixed some titles and nits from the PR feedback.

* Removed unused var.

* Merged in master and updated tests to remove repeat code.
@kibanamachine kibanamachine mentioned this pull request May 11, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 11, 2021
@kibanamachine
Added CIT test for the fail processor. (elastic#95261)
2ce4df1 
* Added CIT test for the fail processor.

* Fixed linter issues.

* Used new functions and helpers.

* Added common test to ensure that a processor type was selected before saving. Fixed some titles and nits from the PR feedback.

* Removed unused var.

* Merged in master and updated tests to remove repeat code.
@kibanamachine kibanamachine mentioned this pull request May 11, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 11, 2021
@kibanamachine
Added CIT test for the fail processor. (elastic#95261)
c4316ab 
* Added CIT test for the fail processor.

* Fixed linter issues.

* Used new functions and helpers.

* Added common test to ensure that a processor type was selected before saving. Fixed some titles and nits from the PR feedback.

* Removed unused var.

* Merged in master and updated tests to remove repeat code.
@kibanamachine kibanamachine mentioned this pull request May 11, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.12
✅ 7.13
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 11, 2021
@kibanamachine
Added CIT test for the fail processor. (#95261) (#99847)
4accfcd 
* Added CIT test for the fail processor.

* Fixed linter issues.

* Used new functions and helpers.

* Added common test to ensure that a processor type was selected before saving. Fixed some titles and nits from the PR feedback.

* Removed unused var.

* Merged in master and updated tests to remove repeat code.

Co-authored-by: John Dorlus <[email protected]>
kibanamachine added a commit that referenced this pull request May 11, 2021
@kibanamachine
Added CIT test for the fail processor. (#95261) (#99846)
902c29b 
* Added CIT test for the fail processor.

* Fixed linter issues.

* Used new functions and helpers.

* Added common test to ensure that a processor type was selected before saving. Fixed some titles and nits from the PR feedback.

* Removed unused var.

* Merged in master and updated tests to remove repeat code.

Co-authored-by: John Dorlus <[email protected]>
kibanamachine added a commit that referenced this pull request May 11, 2021
@kibanamachine
Added CIT test for the fail processor. (#95261) (#99845)
677cb6d 
* Added CIT test for the fail processor.

* Fixed linter issues.

* Used new functions and helpers.

* Added common test to ensure that a processor type was selected before saving. Fixed some titles and nits from the PR feedback.

* Removed unused var.

* Merged in master and updated tests to remove repeat code.

Co-authored-by: John Dorlus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens left review comments

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@yuliacech yuliacech Awaiting requested review from yuliacech

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test-jest-integration v7.12.1 v7.13.0 v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cuff-links @elasticmachine @kibanamachine @alisonelizabeth @yuliacech @jloleysens @spalger