Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [SECURITY_SOLUTION] Adds hash validation on UI for trusted app (#94958) #95080

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

dasansol92
Copy link
Contributor

Backports the following commits to 7.x:

…ic#94958)

* Adds hash validation on UI. Display as many error messages as they are instead of displaying just the first one on entry fields. Updates related unit test

* Fixes failing test and added new test case

Co-authored-by: Kibana Machine <[email protected]>
@dasansol92 dasansol92 enabled auto-merge (squash) March 22, 2021 16:56
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / general / "before all" hook for "should open a modal".Open timeline Open timeline modal "before all" hook for "should open a modal"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="title-43630920-8b3a-11eb-ad16-f1ef4faaa8ce"]`, but never found it.

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `Open timeline`

Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
    at Object.openTimelineById (http://localhost:6111/__cypress/tests?p=cypress/integration/timelines/open_timeline.spec.ts:16088:15)
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/timelines/open_timeline.spec.ts:15046:28)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2203 2204 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.2MB 7.2MB +460.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dasansol92 dasansol92 merged commit 7ebee0f into elastic:7.x Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants