[Maps] Add suggest EMS layer utility #94969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
WIP
thomasneirynck
added
v7.13.0
v8.0.0
chore
release_note:skip
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
reviewed
Mar 31, 2021
| const url = emsFileLayer.getDefaultFormatUrl(); | ||
|
|
||
| try { | ||
| const emsJson = await fetchGeoJson( |
There was a problem hiding this comment.
Should we put these geojson files into some kind of cache so they are not re-fetched everything time the method is run?
There was a problem hiding this comment.
discussed offline. Will push cashing logic in the ems-client. This will also simplify the geojson-fetching in general, pushing format-conversion (if any) into the ems-client as well. cf. elastic/ems-client#60
x-pack/plugins/maps/public/ems_autosuggest/ems_autosuggest.test.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/ems_autosuggest/ems_autosuggest.test.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Apr 1, 2021
thomasneirynck
added a commit
that referenced
this pull request
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
suggestEMSTermJoinConfigutility to MapsPlugin.Based on some sample-values, will suggest a layer and column from EMS that can be used for choropleth mapping.
This is ready for a first look, but this is just a first proposal on how this could work. Tried to keep it simple as a first pass.
Checklist
Delete any items that are not applicable to this PR.
For maintainers