Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY SOLUTION] add enableExperimental plugin configuration setting #94944

Conversation

paul-tavares
Copy link
Contributor

@paul-tavares paul-tavares commented Mar 18, 2021

Summary

Adds a new config setting to the security solution plugin (xpack.securitySolution.enableExperimental) that allows for string values to be defined, which are then used to expose experimental type of features. The value for this new configuration setting must be defined internally in the code, thus only a known set will be accepted.

This new setting will also be exposed to our cloud environments.

Current use case is to use it in preparation for integration with fleet-server (need to ensure existing integration env. continue to work) as well as hiding a feature that has been pulled from v7.13.

olm-enable-experimental-config-setting

For Endpoint Artifact Manifest, it will use Fleet Server relative URLs when fleetServerEnabled is defined via xpack.securitySolution.enableExperimental:

Screen Shot 2021-03-18 at 11 56 33 AM

@paul-tavares paul-tavares added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.13.0 labels Mar 18, 2021
@paul-tavares paul-tavares self-assigned this Mar 18, 2021
@paul-tavares paul-tavares requested a review from a team as a code owner March 18, 2021 16:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@paul-tavares paul-tavares requested review from dasansol92 and pzl March 18, 2021 21:19
Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / general / "before all" hook for "should contain notes".Timeline notes tab "before all" hook for "should contain notes"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="title-b51de5c0-8b1d-11eb-ab4a-01cdbfb76602"]`, but never found it.

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `Timeline notes tab`

Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
    at Object.openTimelineById (http://localhost:61181/__cypress/tests?p=cypress/integration/timelines/notes_tab.spec.ts:16023:15)
    at Context.eval (http://localhost:61181/__cypress/tests?p=cypress/integration/timelines/notes_tab.spec.ts:15041:24)

Kibana Pipeline / general / "after all" hook for "should contain notes".Timeline notes tab "after all" hook for "should contain notes"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

CypressError: `cy.filter()` failed because it requires a DOM element.

The subject received was:

  > `undefined`

The previous command that ran was:

  > `cy.get()`

All 2 subject validations failed on this subject.

Because this error occurred during a `after all` hook we are skipping the remaining tests in the current suite: `Timeline notes tab`

Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
    at ensureElement (http://elastic:changeme@localhost:61181/__cypress/runner/cypress_runner.js:161322:24)
    at validateType (http://elastic:changeme@localhost:61181/__cypress/runner/cypress_runner.js:161159:16)
    at Object.ensureSubjectByType (http://elastic:changeme@localhost:61181/__cypress/runner/cypress_runner.js:161195:9)
    at pushSubjectAndValidate (http://elastic:changeme@localhost:61181/__cypress/runner/cypress_runner.js:169888:15)
    at Context.<anonymous> (http://elastic:changeme@localhost:61181/__cypress/runner/cypress_runner.js:170225:18)
From Your Spec Code:
    at Object.closeTimeline (http://localhost:61181/__cypress/tests?p=cypress/integration/timelines/notes_tab.spec.ts:15976:43)
    at Context.eval (http://localhost:61181/__cypress/tests?p=cypress/integration/timelines/notes_tab.spec.ts:15051:20)

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

@paul-tavares paul-tavares merged commit e7bb8b7 into elastic:master Mar 22, 2021
@paul-tavares paul-tavares deleted the task/olm-switch-fleet-server-feature-flag branch March 22, 2021 15:59
paul-tavares added a commit that referenced this pull request Mar 22, 2021
…ting (#94944) (#95071)

* Added new setting (enableExperimental) to plugin configuration
* Remove plugin config setting `fleetServerEnabled` and use instead `enableExperimental`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants