-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SECURITY SOLUTION] add enableExperimental
plugin configuration setting
#94944
Merged
paul-tavares
merged 9 commits into
elastic:master
from
paul-tavares:task/olm-switch-fleet-server-feature-flag
Mar 22, 2021
Merged
[SECURITY SOLUTION] add enableExperimental
plugin configuration setting
#94944
paul-tavares
merged 9 commits into
elastic:master
from
paul-tavares:task/olm-switch-fleet-server-feature-flag
Mar 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-tavares
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v7.13.0
labels
Mar 18, 2021
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
dasansol92
requested changes
Mar 18, 2021
x-pack/plugins/security_solution/common/experimental_features.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/common/experimental_features.ts
Outdated
Show resolved
Hide resolved
pzl
reviewed
Mar 18, 2021
pzl
approved these changes
Mar 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
dasansol92
approved these changes
Mar 22, 2021
…leet-server-feature-flag
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / "before all" hook for "should contain notes".Timeline notes tab "before all" hook for "should contain notes"Stack Trace
Kibana Pipeline / general / "after all" hook for "should contain notes".Timeline notes tab "after all" hook for "should contain notes"Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v7.13.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new config setting to the security solution plugin (
xpack.securitySolution.enableExperimental
) that allows for string values to be defined, which are then used to expose experimental type of features. The value for this new configuration setting must be defined internally in the code, thus only a known set will be accepted.This new setting will also be exposed to our cloud environments.
Current use case is to use it in preparation for integration with fleet-server (need to ensure existing integration env. continue to work) as well as hiding a feature that has been pulled from v7.13.
For Endpoint Artifact Manifest, it will use Fleet Server relative URLs when
fleetServerEnabled
is defined viaxpack.securitySolution.enableExperimental
: