Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard/bwc_shared_urls] check viz are loaded #94941

Merged
merged 3 commits into from
Mar 22, 2021
Merged

[dashboard/bwc_shared_urls] check viz are loaded #94941

merged 3 commits into from
Mar 22, 2021

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Mar 18, 2021 •
edited
Loading

Summary

PR adds visualisations loading check in order to avoid situation like #78958 when tests passed but visualisations were not loaded.

@dmlemeshko
Copy link
Member Author

@elasticmachine merge upstream

@dmlemeshko dmlemeshko mentioned this pull request Mar 22, 2021
Closed
@dmlemeshko dmlemeshko marked this pull request as ready for review March 22, 2021 13:44
@dmlemeshko dmlemeshko requested a review from a team as a code owner March 22, 2021 13:44
@dmlemeshko dmlemeshko added v7.13.0 v8.0.0 test_ui_functional release_note:skip Skip the PR/issue when compiling release notes labels Mar 22, 2021
@dmlemeshko
Copy link
Member Author

@elasticmachine merge upstream

ThomThomson
ThomThomson approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fixes LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko merged commit 041566d into elastic:master Mar 22, 2021
@dmlemeshko dmlemeshko mentioned this pull request Mar 22, 2021
Merged
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Mar 22, 2021
@dmlemeshko @kibanamachine
[dashboard/bwc_shared_urls] check viz are loaded (elastic#94941)
d99b5e7 
Co-authored-by: Kibana Machine <[email protected]>
stephmilovic pushed a commit that referenced this pull request Mar 22, 2021
@dmlemeshko @kibanamachine @stephmilovic
[dashboard/bwc_shared_urls] check viz are loaded (#94941)
23cf913 
Co-authored-by: Kibana Machine <[email protected]>
dmlemeshko added a commit that referenced this pull request Mar 22, 2021
@dmlemeshko @kibanamachine
[dashboard/bwc_shared_urls] check viz are loaded (#94941) (#95085)
c090bd3 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@dmlemeshko dmlemeshko deleted the tune-dashboard-tests branch January 31, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmlemeshko @kibanamachine @ThomThomson