[dev tools] Hide app link when there are no tools #9489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epixa
reviewed
Dec 14, 2016
| @@ -49,3 +50,11 @@ chrome | |||
| }); | |||
|
|
|||
| modules.get('kibana').run(Notifier.pullMessageFromUrl); | |||
|
|
|||
| modules.get('kibana').run(function (Private) { | |||
There was a problem hiding this comment.
Can you pull this logic out into a standalone export and unit test it?
jbudz
force-pushed
the
hide-empty-devtools
branch
from
d12cdf0 to
a59eb7f
Compare
jbudz
force-pushed
the
hide-empty-devtools
branch
from
a59eb7f to
7828524
Compare
|
LGTM In the absence of a proper integration test for this, can you make sure to add a manual QA test plan for this? |
|
Added |
epixa
approved these changes
Dec 15, 2016
elastic-jasper
added a commit
that referenced
this pull request
Dec 16, 2016
Backports PR #9489 **Commit 1:** [dev tools] Hide app link when there are no tools * Original sha: ace40c4 * Authored by Jonathan Budzenski <[email protected]> on 2016-12-01T18:10:07Z **Commit 2:** [dev tools] Add tests for setting app as hidden * Original sha: 7828524 * Authored by Jonathan Budzenski <[email protected]> on 2016-12-15T21:08:20Z
jbudz
pushed a commit
that referenced
this pull request
Dec 16, 2016
Backports PR #9489 **Commit 1:** [dev tools] Hide app link when there are no tools * Original sha: ace40c4 * Authored by Jonathan Budzenski <[email protected]> on 2016-12-01T18:10:07Z **Commit 2:** [dev tools] Add tests for setting app as hidden * Original sha: 7828524 * Authored by Jonathan Budzenski <[email protected]> on 2016-12-15T21:08:20Z
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Jan 19, 2017
clean up show spy panel in embed mode [webpack] fix loader query string usage (elastic#9497) * [webpack] pin to fork with fixed loader aliases * [optimizer] upgrade to postcss+autoprefixer * [timelion] convert uiExports.modules -> webpackShims * [uiExports] remove implementation-leaking and unused uiExport types * [optimizer] remove unused imports * [uiBundlerEnv] add a method for exporting global import aliases for special cases [dev tools] Hide app link when there are no tools (elastic#9489) * [dev tools] Hide app link when there are no tools * [dev tools] Add tests for setting app as hidden pie chart unhandled error fix (elastic#9422) Add NoResults and Panel components. (elastic#9516) * Add NoResults and Panel components. * Lighten noResults text. Update ToolBarFooter component to support content on the left side. (elastic#9514) Fix bug with Button component appearance inside of a ToolBar. (elastic#9526) Make basic Button hover state the same both in and out of ToolBar. (elastic#9528) [grunt/eslint] fix precommit linting (elastic#9510) * [grunt/eslint] fix precommit linting - remove use of `minimatch.makeRe()` because it does not support the entire glob syntax - log a warning whenever a js file is excluded by the `lintStagedFiles` task - eslint globs are relative to the project root, ensure that we check against relative version * [grunt/eslint] only log warning wtr grunt paths Add Tabs component. (elastic#9536) - Fix bugs with Button and CheckBox focused states. - Fix appearance of cell content in Table. Disable linting for Tabs component example JS. (elastic#9538) Set Button component to display: inline-block, to ensure it has the same height when applied to both button elements and anchor tags. (elastic#9541) fixing metric vis to correctly show scrollbars when overflown (elastic#9481) Adding Safari 7 support to autoprefixer (elastic#9534) PhantomJS is using a rather outdated version of WebKit, which requires various css-prefixes to render correctly. PhantomJS doesn't have a specific user-agent, and Safari 7 is the closet version of WebKit. use Stop Editing instead of Preview Warn the user if they Stop Editing with unsaved changes - Refresh the dashboard after stop editing so unsaved changes are lost and no temporary edits will be shown in non-edit mode. Don't watch the variable on scope, but the config attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9165