[eslint] enable object-curly-spacing and no-global-assign #9486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
eslint/enable/object-curly-spacing+no-global-assign
branch
from
317ebaa to
94f9131
Compare
spalger
force-pushed
the
eslint/enable/object-curly-spacing+no-global-assign
branch
from
94f9131 to
edf7f2c
Compare
7 tasks
cjcenizal
approved these changes
Dec 14, 2016
| [ 6, true, '192.168.0.1', 'php', 'Linux', 40.141592, 'bat' ], | ||
| [ 7, true, '192.168.0.1', 'php', 'Linux', 40.141592, 'bat' ], | ||
| [ 8, true, '192.168.0.1', 'php', 'Linux', 40.141592, 'bat' ], | ||
| [ 9, true, '192.168.0.1', 'php', 'Linux', 40.141592, 'bat' ], |
There was a problem hiding this comment.
Nice solution! At first I was like 😖 but then I was like 😮 and now I'm like 😏
epixa
added
the
Team:Core
spalger
deleted the
eslint/enable/object-curly-spacing+no-global-assign
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@elastic/eslint-config-kibanasrc/fixtures/hits.jsso that it complies with the max-len rule and is more similar tosrc/fixtures/logstash_fields.jsnote: the majority of the changes were automated, the first and last commit were manual