Fix links to the numeral formatting #94858

dokmic · 2021-03-17T20:28:29Z

Summary

Fix a link to the numeral formatting in the index pattern field settings.
Fix links to the numeral formatting in the advanced settings.

Resolves #84167.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

mattkime · 2021-03-17T21:38:43Z

...ex_pattern_field_editor/public/components/field_format_editor/editors/number/number.test.tsx

 describe('NumberFormatEditor', () => {
+  beforeAll(() => {
+    // @see https://github.com/airbnb/enzyme/issues/1553


I'm not sure what this is specifically referencing. Otherwise the code changes look good.

mattkime · 2021-03-17T21:49:18Z

src/plugins/data/server/ui_settings.ts

@@ -417,7 +417,7 @@ export function getUiSettings(): Record<string, UiSettingsParams<unknown>> {
          'data.advancedSettings.format.numberFormat.numeralFormatLinkText',
        values: {
          numeralFormatLink:
-            '<a href="http://numeraljs.com/" target="_blank" rel="noopener noreferrer">' +
+            '<a href="https://www.elastic.co/guide/en/kibana/current/numeral.html" target="_blank" rel="noopener">' +


We should check to see if we can use the docLinks service for this but there's no reason to block this PR.

I spoke to the kibana core team and they're open to doing this - we should create an issue for this. I'll leave this in your hands and help out as needed.

mattkime

Left a couple of comments, just need to resolve the ambiguous comment. I think it would be good to backport this to 7.12 and 7.11 if its not too much trouble.

…#84167)

…ngs (elastic#84167)

kibanamachine · 2021-03-18T13:03:16Z

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	433.4KB	433.4KB	+95.0B
`indexPatternFieldEditor`	82.6KB	82.8KB	+286.0B
total			+381.0B

History

💔 Build #113806 failed 286cb84930e5e46df9dce0f40a1b140c8c6b8f2d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dokmic · 2021-03-18T13:15:30Z

@mattkime I've updated the comment to clarify the workaround. There were some failed tests, so I pushed other changes. Could you please take another look?

mattkime

looks good and works well!

TinaHeiligers

Core Changes LGTM

* Fix links to the numeral formatting in the advanced settings (elastic#84167) * Fix a link to the numeral formatting in the index pattern field settings (elastic#84167) # Conflicts: # docs/development/core/public/kibana-plugin-core-public.doclinksstart.md

* Fix links to the numeral formatting in the advanced settings (elastic#84167) * Fix a link to the numeral formatting in the index pattern field settings (elastic#84167) # Conflicts: # docs/development/core/public/kibana-plugin-core-public.doclinksstart.md # src/core/public/doc_links/doc_links_service.ts # src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/bytes/__snapshots__/bytes.test.tsx.snap # src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/number/__snapshots__/number.test.tsx.snap # src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/number/number.tsx # src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/percent/__snapshots__/percent.test.tsx.snap # src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/percent/percent.test.tsx

* Fix links to the numeral formatting in the advanced settings (#84167) * Fix a link to the numeral formatting in the index pattern field settings (#84167) # Conflicts: # docs/development/core/public/kibana-plugin-core-public.doclinksstart.md

* Fix links to the numeral formatting in the advanced settings (#84167) * Fix a link to the numeral formatting in the index pattern field settings (#84167) # Conflicts: # docs/development/core/public/kibana-plugin-core-public.doclinksstart.md # src/core/public/doc_links/doc_links_service.ts # src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/bytes/__snapshots__/bytes.test.tsx.snap # src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/number/__snapshots__/number.test.tsx.snap # src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/number/number.tsx # src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/percent/__snapshots__/percent.test.tsx.snap # src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/percent/percent.test.tsx

dokmic requested review from a team as code owners March 17, 2021 20:28

dokmic added release_note:fix Feature:FieldFormatters Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages v7.13.0 v8.0.0 review labels Mar 17, 2021

mattkime reviewed Mar 17, 2021

View reviewed changes

mattkime requested changes Mar 17, 2021

View reviewed changes

dokmic added 2 commits March 18, 2021 11:00

Fix links to the numeral formatting in the advanced settings (elastic…

e294e89

…#84167)

Fix a link to the numeral formatting in the index pattern field setti…

a6c8a9b

…ngs (elastic#84167)

dokmic force-pushed the bugfix/84167 branch from 286cb84 to a6c8a9b Compare March 18, 2021 10:59

mattkime approved these changes Mar 18, 2021

View reviewed changes

dokmic added v7.11.3 v7.12.1 labels Mar 18, 2021

TinaHeiligers approved these changes Mar 18, 2021

View reviewed changes

dokmic merged commit e9568ce into elastic:master Mar 18, 2021

dokmic mentioned this pull request Mar 18, 2021

[7.x] Fix links to the numeral formatting (#94858) #94945

Merged

dokmic mentioned this pull request Mar 18, 2021

[7.12] Fix links to the numeral formatting (#94858) #94954

Merged

dokmic mentioned this pull request Mar 18, 2021

[7.11] Fix links to the numeral formatting (#94858) #94957

Merged

dokmic deleted the bugfix/84167 branch March 22, 2021 09:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix links to the numeral formatting #94858

Fix links to the numeral formatting #94858

dokmic commented Mar 17, 2021 •

edited

Loading

mattkime Mar 17, 2021

mattkime Mar 17, 2021 •

edited

Loading

mattkime left a comment

kibanamachine commented Mar 18, 2021

dokmic commented Mar 18, 2021

mattkime left a comment

TinaHeiligers left a comment

Fix links to the numeral formatting #94858

Fix links to the numeral formatting #94858

Conversation

dokmic commented Mar 17, 2021 • edited Loading

Summary

Checklist

mattkime Mar 17, 2021

Choose a reason for hiding this comment

mattkime Mar 17, 2021 • edited Loading

Choose a reason for hiding this comment

mattkime left a comment

Choose a reason for hiding this comment

kibanamachine commented Mar 18, 2021

💚 Build Succeeded

Metrics [docs]

Page load bundle

History

dokmic commented Mar 18, 2021

mattkime left a comment

Choose a reason for hiding this comment

TinaHeiligers left a comment

Choose a reason for hiding this comment

dokmic commented Mar 17, 2021 •

edited

Loading

mattkime Mar 17, 2021 •

edited

Loading