Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] docs: Correlations #94620

Merged
merged 4 commits into from
Mar 16, 2021
Merged

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Mar 15, 2021

Summary

This PR adds documentation for APM's new correlations feature.

Doc preview

Click here for a preview

Related

For #86477.
Implementation #89952.

@bmorelli25 bmorelli25 requested a review from a team as a code owner March 15, 2021 18:03
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Mar 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@bmorelli25 bmorelli25 requested a review from ogupte March 15, 2021 18:03
@bmorelli25 bmorelli25 self-assigned this Mar 15, 2021
@bmorelli25 bmorelli25 added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Mar 15, 2021
@ogupte
Copy link
Contributor

ogupte commented Mar 15, 2021

One thing we'll definitely want to include/illustrate is the ability to hover over a specific significant term/value in the table to compare it with the overall distribution in latency/failures. For example, Here's a screenshot with a interesting curve in latency distribution related to one specific browser type:
Screen Shot 2021-03-15 at 3 12 55 PM
The next step would be to filter by user_agent.name: "HeadlessChrome" in the rest of APM and maybe look at a sample trace.

@bmorelli25
Copy link
Member Author

Thanks, Oliver! Updated the docs to reflect that flow.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.3MB 5.3MB -4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bmorelli25

Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

With a service selected, click **View correlations**:

[role="screenshot"]
image::apm/images/correlations.png[Correlations]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorelli25 I noticed for all the screenshots that we're using the v8 theme - was this decided within the docs team that any new screenshots would use the "not yet" released theme? Just wondering since I don't think we're shipping the theme publically until a few minors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 This is an oversight on my part

@formgeist
Copy link
Contributor

formgeist commented Mar 16, 2021

@bmorelli25 Great read! You made it sound a lot less complicated ;)

=== Find latency and error correlations

**Correlations** surfaces attributes of your data that are potentially correlated with high-latency or erroneous transactions.
Surfaced attributes are user-defined, meaning that they are completely customizable to your APM data.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does user-defined mean here? My suggestion is to frame this as the surfaced attributes are some of the default attributes that are commonly known to cause performance issues like version/infrastructure and can be modified to include any attributes for custom analysis.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Fixed in #94750.

docs/apm/correlations.asciidoc Show resolved Hide resolved
docs/apm/correlations.asciidoc Outdated Show resolved Hide resolved
docs/apm/correlations.asciidoc Outdated Show resolved Hide resolved
docs/apm/correlations.asciidoc Outdated Show resolved Hide resolved
docs/apm/correlations.asciidoc Show resolved Hide resolved
@bmorelli25
Copy link
Member Author

Thanks for the reviews, everyone! Merging this in as-is and will open a follow-up PR addressing review feedback.

@bmorelli25 bmorelli25 merged commit 0e1a2cd into elastic:master Mar 16, 2021
@bmorelli25 bmorelli25 deleted the doc-correlations branch March 16, 2021 17:13
bmorelli25 added a commit to bmorelli25/kibana that referenced this pull request Mar 16, 2021
bmorelli25 added a commit to bmorelli25/kibana that referenced this pull request Mar 16, 2021
@bmorelli25
Copy link
Member Author

Feedback addressed in #94750.

bmorelli25 added a commit that referenced this pull request Mar 16, 2021
bmorelli25 added a commit that referenced this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants