Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display correct reset terminology for single layer visualizations #94539

Merged
merged 4 commits into from
Mar 16, 2021
Merged

Display correct reset terminology for single layer visualizations #94539

merged 4 commits into from
Mar 16, 2021

Conversation

anish-khanna
Copy link
Contributor

Summary

Fixes #93412

Changes 'Reset layer' terminology for single layer visualizations to 'Reset Visualization'

Before:
image

After
image

Checklist

Delete any items that are not applicable to this PR.

  • Unit or functional tests were updated or added to match the most common scenarios
  • Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

For maintainers

@anish-khanna anish-khanna requested a review from a team March 15, 2021 00:40
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 15, 2021 •
edited
Loading

💚 CLA has been signed

@anish-khanna
Copy link
Contributor Author

I have signed the Contributor Agreement. I'm unsure about why the bot has not verified that. Please advise on next steps regarding that.

@flash1293 flash1293 added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0 labels Mar 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@flash1293 flash1293 added the release_note:skip Skip the PR/issue when compiling release notes label Mar 15, 2021
@flash1293
Copy link
Contributor

Jenkins, test this.

@flash1293
Copy link
Contributor

@anish-khanna Make sure to sign the CLA with the same email address your are using in your commits (git config --global user.email). If you used the wrong mail in there by accident, either sign the CLA under that email again or change the email of the commit and force push the updated commit

@timroes
Copy link
Contributor

timroes commented Mar 15, 2021

You used your @edu.uwaterloo.ca mail for creating the PR, but signed the CLA with a @gmail.com address. Please either sign the CLA with that edu.uwaterloo.ca address or change the commits to use the @gmail.com address as @flash1293 suggested.

@anish-khanna
Copy link
Contributor Author

I've re-signed the CLA with my edu.uwaterloo.ca email.

@flash1293 flash1293 self-assigned this Mar 16, 2021
flash1293
flash1293 approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome and works as expected, thanks for adding a unit test as well. LGTM.

Great job!

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@flash1293
Copy link
Contributor

Jenkins, test this

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@flash1293
Copy link
Contributor

Jenkins, test this.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 935.3KB 935.8KB +500.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @flash1293

@flash1293 flash1293 added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 16, 2021
@flash1293 flash1293 merged commit 9e24406 into elastic:master Mar 16, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 16, 2021
@anish-khanna @kibanamachine
Display correct reset terminology for visualizations (elastic#94539)
f9f378c 
Co-authored-by: Anish Khanna <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Mar 16, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #94732

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 16, 2021
@kibanamachine @anish-khanna
Display correct reset terminology for visualizations (#94539) (#94732)
f88b143 
Co-authored-by: Anish Khanna <[email protected]>

Co-authored-by: Anish Khanna <[email protected]>
Co-authored-by: Anish Khanna <[email protected]>
@anish-khanna anish-khanna deleted the fix-reset-button branch March 16, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

@flash1293 flash1293

Labels
auto-backport Deprecated - use backport:version if exact versions are needed 💝community Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Rename "reset layer" in single layer visualizations
5 participants
@anish-khanna @kibanamachine @elasticmachine @flash1293 @timroes