[Security Solution][Preview] - Enable preview when only filters used #94018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yctercero
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
dplumlee
approved these changes
Mar 8, 2021
| eqlQueryLoading || | ||
| isDisabled || | ||
| query == null || | ||
| (query != null && query.query.query === '' && query.filters.length === 0) |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @yctercero |
yctercero
added a commit
to yctercero/kibana
that referenced
this pull request
Mar 9, 2021
…lastic#94018) ### Summary Addresses elastic#93245 where the preview button was grayed out when only filters were present - no main query. # Conflicts: # x-pack/plugins/security_solution/public/detections/components/rules/query_preview/index.test.tsx
yctercero
added a commit
to yctercero/kibana
that referenced
this pull request
Mar 9, 2021
…lastic#94018) ### Summary Addresses elastic#93245 where the preview button was grayed out when only filters were present - no main query. # Conflicts: # x-pack/plugins/security_solution/public/detections/components/rules/query_preview/index.test.tsx
yctercero
added a commit
that referenced
this pull request
Mar 9, 2021
…s used (#94018) (#94045) * [Security Solution][Preview] - Enable preview when only filters used (#94018) ### Summary Addresses #93245 where the preview button was grayed out when only filters were present - no main query. # Conflicts: # x-pack/plugins/security_solution/public/detections/components/rules/query_preview/index.test.tsx * fixing merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #93245 where the preview button was grayed out when only filters were present - no main query.
Adds unit tests.
Checklist