Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY SOLUTION] BUG Manual Alert in case #93726

Merged
merged 3 commits into from
Mar 8, 2021
Merged

[SECURITY SOLUTION] BUG Manual Alert in case #93726

merged 3 commits into from
Mar 8, 2021

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Mar 5, 2021 •
edited
Loading

Summary

bug coming from #93568

  • on 7.11.1
    Comment : Elastic added an alert from Malware detection alert
    image

  • After upgrading to 7.12.0

    • Malware detection rule name got changed to Unknown rule. 🔴
      image

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:critical This issue should be addressed immediately due to a critical level of impact on the product. v7.12.0 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Mar 5, 2021
@XavierM XavierM requested a review from a team as a code owner March 5, 2021 02:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

jonathan-buttner
jonathan-buttner approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested by migrating an attached alert from 7.11 to master

image

@cnasikas
Copy link
Member

cnasikas commented Mar 8, 2021

I think we should fix the layout (appearance of Unknown rule) when indeed the rule is missing. This can be happen when the user deletes an alert.

@cnasikas
Copy link
Member

cnasikas commented Mar 8, 2021 •
edited
Loading

Commit e2ad8af (#93726):

Screenshot 2021-03-08 at 8 30 46 PM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.8MB 7.8MB +284.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 5d96e5f into elastic:master Mar 8, 2021
@XavierM XavierM mentioned this pull request Mar 8, 2021
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request Mar 8, 2021
@XavierM @cnasikas
[SECURITY SOLUTION] BUG Manual Alert in case (elastic#93726)
39781f9 
* get the data where it belongs

* Fix layout when alert is deleted

Co-authored-by: Christos Nasikas <[email protected]>
XavierM added a commit to XavierM/kibana that referenced this pull request Mar 8, 2021
@XavierM @cnasikas
[SECURITY SOLUTION] BUG Manual Alert in case (elastic#93726)
2025319 
* get the data where it belongs

* Fix layout when alert is deleted

Co-authored-by: Christos Nasikas <[email protected]>
@XavierM XavierM mentioned this pull request Mar 8, 2021
Merged
XavierM added a commit that referenced this pull request Mar 8, 2021
@XavierM @cnasikas
[SECURITY SOLUTION] BUG Manual Alert in case (#93726) (#94008)
c1f4de8 
* get the data where it belongs

* Fix layout when alert is deleted

Co-authored-by: Christos Nasikas <[email protected]>

Co-authored-by: Christos Nasikas <[email protected]>
@cnasikas cnasikas mentioned this pull request Mar 9, 2021
Closed
30 tasks
XavierM added a commit that referenced this pull request Mar 9, 2021
@XavierM @cnasikas
[SECURITY SOLUTION] BUG Manual Alert in case (#93726) (#94009)
2b39588 
* get the data where it belongs

* Fix layout when alert is deleted

Co-authored-by: Christos Nasikas <[email protected]>

Co-authored-by: Christos Nasikas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XavierM @elasticmachine @cnasikas @kibanamachine @jonathan-buttner