Visualize: Upgrading vis with pipeline agg from 6.8 doesn't render

[VladLasitsa]

Closes: #93026

Summary

As I understand start from 7.12 version we don't support 'schema' as object and should use the name of schema instead. Created migartion function find all schemes object in aggregation and replace it on name of this schema.

Schema before migration:

After migration:

[lukeelmers]

The change here makes sense to me, but it might be good to also get @ppisljar to take a look since he did much of the schema refactoring.

[alexwizp]

Looks good to me! thank you

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[flash1293]

Didn't do a deep dive but this export still doesn't render for me (with errors in the console): https://gist.github.com/flash1293/ba8a4cf238e16942d68161f1fee41541

[VladLasitsa]

Didn't do a deep dive but this export still doesn't render for me (with errors in the console): https://gist.github.com/flash1293/ba8a4cf238e16942d68161f1fee41541

@flash1293 , I think it because this export already have version 7.12.

[flash1293]

My bad @VladLasitsa , all my test cases work fine now, thanks!

[stratoula]

@VladLasitsa this fails only when I upgrade from 6.8 to 7.12? It works for 7.11.x right? So this means that this bug doesn't exist yet (for the users). If this is the case, I would recommend replacing the fix label with the skip one. Unless this bug is live.

[VladLasitsa]

@elasticmachine merge upstream

[VladLasitsa]

@VladLasitsa this fails only when I upgrade from 6.8 to 7.12? It works for 7.11.x right? So this means that this bug doesn't exist yet (for the users). If this is the case, I would recommend replacing the fix label with the skip one. Unless this bug is live.

Joe has written in issue that in 7.11 works fine. So in this case I will replace label.

[ppisljar]

code LGTM

[stratoula]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 8a1e726
• Storybooks Preview

Metrics [docs]

✅ unchanged

History

• 💚 Build #111375 succeeded c824535
• 💚 Build #110729 succeeded ab12b0f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

[stratoula]

@elasticmachine run elasticsearch-ci/docs

[nodakai]

Hi, I have a strong suspicion that this matters to, at least, 7.11.1 as well. After we upgraded our Kibana installation to kibana-7.11.1-1.x86_64, some of our visualizations which we created long before broke and Firefox console showed something like

Uncaught (in promise) Error: Objects must have a type property
    getType expressions.plugin.js:4002
    getArgumentString expressions.plugin.js:5942
    getExpressionArgs expressions.plugin.js:5965
    getExpressionArgs expressions.plugin.js:5964
    getExpressionArgs expressions.plugin.js:5964
    getExpression expressions.plugin.js:5986

Saved objects -> Inspect shows "schema": { ... } under customMetric of the broken visualization

[VladLasitsa]

Hi, I have a strong suspicion that this matters to, at least, 7.11.1 as well. After we upgraded our Kibana installation to kibana-7.11.1-1.x86_64, some of our visualizations which we created long before broke and Firefox console showed something like

Uncaught (in promise) Error: Objects must have a type property
    getType expressions.plugin.js:4002
    getArgumentString expressions.plugin.js:5942
    getExpressionArgs expressions.plugin.js:5965
    getExpressionArgs expressions.plugin.js:5964
    getExpressionArgs expressions.plugin.js:5964
    getExpression expressions.plugin.js:5986

Saved objects -> Inspect shows "schema": { ... } under customMetric of the broken visualization

Hi @flash1293 , as you see @nodakai find out that in 7.11.1 old visualizations doesn't work due to problem which I fixed in this PR. In the issue (#93026) you have written that in 7.11 old visualizations work fine. Because of this I have worked on this issue starting check from 7.12. As a result I added migration script for 7.12. Should we move migration script to 7.11 or should we leave as now and ask users modify visualizations manually?

[nodakai]

I used the Inspect screen to search & destroy schema objects like the migration script would do, and that actually fixed our visualizations. Just FYI

[flash1293]

@VladLasitsa In the issue I wrote

Upgrade from 7.11 works fine AFAICT

I tested upgrading a vis saved in 7.11 to 7.12 (I didn't test 6.8 to 7.11 - from 7.11, not to 7.11)

We can't change migration scripts for versions which are already released - the only option is to backport this migration to 7.11.2 . cc @stratoula not sure whether it's worth it, what do you think?

7.12 should be out soon, but it's a pretty bad bug - kind of on the fence here

[stratoula]

Yes, I don't think it worths it either and I think we can't backport it on 7.11.2. It is a bad bug, I will talk to @KOTungseth to see if we could at least include it in the bugs solved section. This is the reason I wanted to be sure here #93427 (comment)