[Metrics UI] Fix removing warning threshold from alert expressions #93338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacqary
added
Feature:Metrics UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
neptunian
approved these changes
Mar 3, 2021
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Mar 3, 2021
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Mar 3, 2021
Zacqary
added a commit
that referenced
this pull request
Mar 3, 2021
Zacqary
added a commit
that referenced
this pull request
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves a bug uncovered in #92665
Each expression row in Metrics alert types are passed a
setAlertParamsfunction that's supposed to take all of an alert condition's required parameters as input. The underlying function was overcorrecting for this, and applying a spread operator of the pre-existing parameters. This effectively made it impossible to remove optional parameters.