Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds x-pack to Jest integration tests #93331

Closed

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Mar 2, 2021

X-Pack integration tests were not running - this re-enables them and fixes the failing tests.

@tylersmalley tylersmalley force-pushed the x-pack-integration-tests branch 2 times, most recently from b5c938b to 44c2ddc Compare March 2, 2021 22:20
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 labels Mar 2, 2021
@tylersmalley tylersmalley force-pushed the x-pack-integration-tests branch from 44c2ddc to a4933a7 Compare March 2, 2021 22:23
@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@tylersmalley tylersmalley force-pushed the x-pack-integration-tests branch from a4933a7 to 93ea6a0 Compare March 9, 2021 22:26
@tsullivan
Copy link
Member

@tylersmalley bumping this :)

@tylersmalley
Copy link
Contributor Author

Oh shoot, sorry @tsullivan

@spalger spalger added v7.14.0 and removed v7.13.0 labels Apr 21, 2021
@spalger spalger added v7.15.0 and removed v7.14.0 labels Jun 30, 2021
@tsullivan
Copy link
Member

@tylersmalley are x-pack jest integration tests running?

I'm thinking #102919 happens because they are...

@mshustov
Copy link
Contributor

mshustov commented Aug 2, 2021

@tsullivan Isn't it happen because Kibana allows the integration tests to be run against the dist with x-pack code included? IMO it's a valid case because we don't ship oss dist anymore, so we should get rid of oss/non-oss separation in the tests.
Another question: Do we download Chromium binary in FTR tests?

@tylersmalley tylersmalley force-pushed the x-pack-integration-tests branch from 0c205ae to 75ee7b4 Compare August 12, 2021 19:16
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 12, 2021

💔 Build Failed

Failed CI Steps


Test Failures

Kibana Pipeline / general / Jest Integration Tests.src/core/server/http/integration_tests.Auth allows manipulating cookies via cookie session storage

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

TypeError: Cannot read property 'cookie' of undefined
    at Object.<anonymous> (/dev/shm/workspace/parallel/8/kibana/src/core/server/http/integration_tests/lifecycle.test.ts:830:35)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _callCircusTest (/dev/shm/workspace/parallel/8/kibana/node_modules/jest-circus/build/run.js:212:5)
    at _runTest (/dev/shm/workspace/parallel/8/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/dev/shm/workspace/parallel/8/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/dev/shm/workspace/parallel/8/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/dev/shm/workspace/parallel/8/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/dev/shm/workspace/parallel/8/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/dev/shm/workspace/parallel/8/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/dev/shm/workspace/parallel/8/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/dev/shm/workspace/parallel/8/kibana/node_modules/jest-runner/build/runTest.js:472:34)

Metrics [docs]

✅ unchanged

History

  • 💔 Build #116950 failed 93ea6a0c6039de3154ab85b921c6bd8e463aa03c
  • 💔 Build #112304 failed 93ea6a0c6039de3154ab85b921c6bd8e463aa03c
  • 💔 Build #110552 failed a4933a72f775bc1c64367f8890c66147c4fb26f4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic added v7.16.0 and removed v7.15.0 labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants