[5.x] Save/rename flow fix #9333
Merged
+269
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports PR #9087 **Commit 1:** Save/rename flow fix - Use auto generated ids instead of coupling the id to the title which creates problems. - Adjust UI to make the save flow more understandable. - Remove confirmation on overwrite since we will now be creating duplicate objects even if they have the same title. * Original sha: faf3e9c * Authored by Stacey Gammon <[email protected]> on 2016-11-15T20:45:16Z **Commit 2:** use undefined instead of null * Original sha: 08b0e92 * Authored by Stacey Gammon <[email protected]> on 2016-11-21T17:35:56Z **Commit 3:** Change titleChanged function name * Original sha: b7b6e0a * Authored by Stacey Gammon <[email protected]> on 2016-11-21T17:40:35Z **Commit 4:** Merge branch 'master' of https://github.com/elastic/kibana into saved_object_refactor * Original sha: 07901bd * Authored by Stacey Gammon <[email protected]> on 2016-11-21T20:58:09Z **Commit 5:** address code review comments * Original sha: 41441bf * Authored by Stacey Gammon <[email protected]> on 2016-11-22T20:10:09Z **Commit 6:** Merge branch 'master' of https://github.com/elastic/kibana into saved_object_refactor * Original sha: e3ff0ad * Authored by Stacey Gammon <[email protected]> on 2016-11-28T14:43:23Z **Commit 7:** Add isSaving flag to avoid checkbox flicker, fix regression bug from refactor. Added tests and fixed a couple bugs Updated info message * Original sha: cf04dde * Authored by Stacey Gammon <[email protected]> on 2016-11-28T14:45:52Z **Commit 8:** Update doc and nav title with new name on rename don't hardcode Dashboard * Original sha: 9686b2a * Authored by Stacey Gammon <[email protected]> on 2016-11-30T21:08:59Z **Commit 9:** Merge branch 'master' of https://github.com/elastic/kibana into saved_object_refactor * Original sha: cb6f918 * Authored by Stacey Gammon <[email protected]> on 2016-12-02T14:23:30Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save/rename flow fix
Backports PR #9087
Commit 1:
Save/rename flow fix
creates problems.
duplicate objects even if they have the same title.
Commit 2:
use undefined instead of null
Commit 3:
Change titleChanged function name
Commit 4:
Merge branch 'master' of https://github.com/elastic/kibana into saved_object_refactor
Commit 5:
address code review comments
Commit 6:
Merge branch 'master' of https://github.com/elastic/kibana into saved_object_refactor
Commit 7:
Add isSaving flag to avoid checkbox flicker, fix regression bug from refactor.
Added tests and fixed a couple bugs
Updated info message
Commit 8:
Update doc and nav title with new name on rename
don't hardcode Dashboard
Commit 9:
Merge branch 'master' of https://github.com/elastic/kibana into saved_object_refactor