Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.12] [Alerting][Docs] Moved alerting links from hard-coded to documentation link service. (#92953) #93322

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

YulNaumenko
Copy link
Contributor

Backports the following commits to 7.12:

…n link service. (elastic#92953)

* [Alerting][Docs] Moved alerting links from hard-coded to documentation link service

* fixed due to comments

* Update x-pack/plugins/triggers_actions_ui/public/application/components/health_check.tsx

Co-authored-by: Mike Côté <[email protected]>

* fixed jest tests

* fixed due to comments

Co-authored-by: Mike Côté <[email protected]>
@YulNaumenko YulNaumenko enabled auto-merge (squash) March 2, 2021 21:44
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / general / adds correctly a filter to the global search bar.SearchBar adds correctly a filter to the global search bar

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 19 times on tracked branches: https://github.com/elastic/kibana/issues/69595

AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="comboBoxOptionsList filterFieldSuggestionList-optionsList"] button[title="host.ip"] mark`, but never found it.
    at Object.fillAddFilterForm (http://localhost:6121/__cypress/tests?p=cypress/integration/header/search_bar.spec.ts:15733:8)
    at Context.eval (http://localhost:6121/__cypress/tests?p=cypress/integration/header/search_bar.spec.ts:15036:22)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackAlerts 682.7KB 682.6KB -80.0B
triggersActionsUi 1.4MB 1.4MB -2.0KB
total -2.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 477.4KB 477.6KB +286.0B
stackAlerts 19.2KB 19.0KB -180.0B
total +106.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko merged commit 0398d35 into elastic:7.12 Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants