Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Case] Fix individual case deletion on case view #93218

Merged
merged 5 commits into from
Mar 3, 2021
Merged

[Security Solution][Case] Fix individual case deletion on case view #93218

merged 5 commits into from
Mar 3, 2021

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Mar 2, 2021 •
edited
Loading

Summary

Divider before:

Screenshot 2021-03-02 at 4 03 33 PM

Divider after:

Screenshot 2021-03-02 at 4 02 55 PM

Meta: #91843

For maintainers

@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience v8.0.0 v7.12.0 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.13.0 labels Mar 2, 2021
@cnasikas cnasikas requested a review from a team March 2, 2021 14:02
@cnasikas cnasikas self-assigned this Mar 2, 2021
@cnasikas cnasikas requested a review from a team as a code owner March 2, 2021 14:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@cnasikas cnasikas added the release_note:skip Skip the PR/issue when compiling release notes label Mar 2, 2021
@cnasikas cnasikas force-pushed the fix_subcases_bugs_v2 branch from cf9d59f to d339b7e Compare March 2, 2021 16:01
angorayc
angorayc reviewed Mar 2, 2021
View reviewed changes
x-pack/plugins/security_solution/public/cases/components/all_cases/index.tsx Outdated
const convertToDeleteCases: DeleteCase[] = caseIds.map((id) => ({ id }));
const convertToDeleteCases: DeleteCase[] = caseIds.map((id) => ({
id,
type: CaseType.individual,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we can set type to individual here. We are still able to bulk delete case collection, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, you are right. I forgot about collections.

angorayc
angorayc reviewed Mar 2, 2021
View reviewed changes
x-pack/plugins/security_solution/public/cases/components/case_view/index.tsx
@@ -397,27 +397,29 @@ export const CaseComponent = React.memo<CaseProps>(
userCanCrud={userCanCrud}
/>
{(caseData.type !== CaseType.collection || hasDataToPush) && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm that sub cases would be rendered the same UI as case individual right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right!

@cnasikas cnasikas force-pushed the fix_subcases_bugs_v2 branch from d339b7e to e3893ca Compare March 2, 2021 18:39
@cnasikas cnasikas mentioned this pull request Mar 3, 2021
Closed
30 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.8MB 7.8MB -42.0B
triggersActionsUi 1.6MB 1.5MB -23.9KB
total -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.1KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas merged commit 1c01902 into elastic:master Mar 3, 2021
@cnasikas cnasikas deleted the fix_subcases_bugs_v2 branch March 3, 2021 13:36
@cnasikas cnasikas mentioned this pull request Mar 3, 2021
Merged
cnasikas added a commit that referenced this pull request Mar 3, 2021
@cnasikas
[Security Solution][Case] Fix individual case deletion on case view (#…
7ccb82c 
…93218) (#93422)
@cnasikas cnasikas mentioned this pull request Mar 4, 2021
Merged
cnasikas added a commit that referenced this pull request Mar 4, 2021
@cnasikas
[Security Solution][Case] Fix individual case deletion on case view (#…
8c8993d 
…93218) (#93564)

# Conflicts:
#	x-pack/plugins/security_solution/public/cases/components/bulk_actions/index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees

@cnasikas cnasikas

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cnasikas @elasticmachine @kibanamachine @angorayc