Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metric visualization layout breakage #93015

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Fix metric visualization layout breakage #93015

merged 1 commit into from
Mar 1, 2021

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Mar 1, 2021 •
edited
Loading

Summary

Fixes #92796

With fix applied:

image

This was checked both in Visulize & Dashboard plugins in Chrome, Safari and Firefox browsers. Both layouts - horizontal and vertical (on small screen) works well.

Checklist

Delete any items that are not applicable to this PR.

  • This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

For maintainers

@sulemanof sulemanof requested a review from stratoula March 1, 2021 12:08
stratoula
stratoula approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanx Daniil 🙂

@sulemanof sulemanof added Feature:MetricVis Metric visualization feature release_note:skip Skip the PR/issue when compiling release notes labels Mar 1, 2021
@sulemanof sulemanof marked this pull request as ready for review March 1, 2021 13:40
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeMetric 19.2KB 20.7KB +1.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@sulemanof sulemanof merged commit 81088a6 into elastic:7.12 Mar 1, 2021
@sulemanof sulemanof deleted the fix/metric_vis_overflow branch March 1, 2021 15:15
@sulemanof sulemanof mentioned this pull request Mar 1, 2021
Merged
sulemanof pushed a commit to sulemanof/kibana that referenced this pull request Mar 1, 2021
Fix visualization overflow (elastic#93015)
010f523
sulemanof pushed a commit that referenced this pull request Mar 2, 2021
Fix visualization overflow (#93015) (#93042)
c7a06d6
@sulemanof sulemanof mentioned this pull request Mar 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
Feature:MetricVis Metric visualization feature release_note:skip Skip the PR/issue when compiling release notes v7.11.2 v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sulemanof @kibanamachine @stratoula