Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-new-docs] Adds a dev-doc for core documentation #92976

Conversation

TinaHeiligers
Copy link
Contributor

Adds a new dev doc for housing core documentation in the new system.
There is a related PR (elastic/elastic-docs#266) in the new docs system to have the new section appear in the nav.

@TinaHeiligers TinaHeiligers added Team:Docs Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes docs v7.13.0 labels Feb 26, 2021
@TinaHeiligers TinaHeiligers requested review from joshdover and a team and removed request for joshdover February 26, 2021 18:07
@TinaHeiligers TinaHeiligers marked this pull request as ready for review March 3, 2021 18:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@TinaHeiligers
Copy link
Contributor Author

@stacey-gammon this PR adds the new section for core and updates links.


Core is a set of systems (frontend, backend etc.) that Kibana and its plugins are built on top of.

## Integration with the "legacy" Kibana
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll probably want to rewrite some of this eventually, but for now since you're just copying from the existing README, it's probably fine to keep as-is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my thinking too. It will be a team effort and we'll probably need to set time aside before the new docs system "goes live". For now, I just wanted to add somewhere to house core's documentation.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 3, 2021
@TinaHeiligers TinaHeiligers merged commit c2bfa87 into elastic:master Mar 3, 2021
@TinaHeiligers TinaHeiligers deleted the core-docs/server-and-core-components branch March 3, 2021 20:37
@kibanamachine
Copy link
Contributor

💔 Backport failed

❌ 7.x: Commit could not be cherrypicked due to conflicts

To backport manually, check out the target branch and run:
node scripts/backport --pr 92976

TinaHeiligers added a commit to TinaHeiligers/kibana that referenced this pull request Mar 3, 2021
# Conflicts:
#	src/core/CORE_CONVENTIONS.md
#	src/core/README.md
TinaHeiligers added a commit that referenced this pull request Mar 3, 2021
# Conflicts:
#	src/core/CORE_CONVENTIONS.md
#	src/core/README.md
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 4, 2021
* master: (48 commits)
  Fix wrong import in data plugin causing 100kB bundle increase (elastic#93448)
  [Fleet] Correctly track install status of an integration (elastic#93464)
  Reviews data frame analytics UI text (elastic#93033)
  Display multiple copyable fields for process.args in resolver node detail panel (elastic#93280)
  [Security Solution][Detections] ML Popover overflow fix (elastic#93525)
  chore(NA): do not use execa on bazel workspace status update script (elastic#93532)
  Bump dependencies (elastic#93511)
  [dev/build_ts_refs] support disabling the ts-refs build completely (elastic#93529)
  [Security Solution] fix data provider cypress test (elastic#93465)
  Fix service map for All environment single service (elastic#93517)
  [Fleet] Fix package version comparaison in the UI (elastic#93498)
  [alerting] adds doc on JSON-expanded action variables and task manager max_workers (elastic#92720)
  [dev/build_ts_refs] ignore type checking failures when building ts refs (elastic#93473)
  [core-new-docs] Adds a dev-doc for core documentation (elastic#92976)
  remove opacity from maps legacy style (elastic#93456)
  [Security Solution][Lists] Escape quotes in list ids and quote the id in KQL query (elastic#93176)
  Revert "Make tests deterministic by providing unique timestamps (elastic#93350)"
  [Discover] Fix link from dashboard saved search to Discover (elastic#92937)
  update public api docs
  App Search - Polishing Analytics Views (elastic#92939)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants