[Security Solution][Endpoint][Admin] Fixes policy sticky footer save test #92919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkiino
changed the title
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
parkiino
added
Feature:Endpoint
|
Pinging @elastic/esecurity-onboarding-and-lifecycle-mgt (Feature:Endpoint) |
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
kevinlog
reviewed
Mar 1, 2021
|
|
||
| // Make sure the toast button closes so the save button on the sticky footer is visible | ||
| await (await testSubjects.find('toastCloseButton')).click(); | ||
| await testSubjects.waitForHidden('toastCloseButton'); |
kevinlog
reviewed
Mar 1, 2021
| @@ -70,7 +69,6 @@ export function EndpointPolicyPageProvider({ getService, getPageObjects }: FtrPr | |||
| */ | |||
| async confirmAndSave() { | |||
| await this.ensureIsOnDetailsPage(); | |||
| await browser.scrollTop(); | |||
There was a problem hiding this comment.
with the save button in the sticky now, this makes sense
kevinlog
approved these changes
Mar 1, 2021
parkiino
added a commit
to parkiino/kibana
that referenced
this pull request
Mar 1, 2021
…test (elastic#92919) * commented code to close out toast
parkiino
added a commit
to parkiino/kibana
that referenced
this pull request
Mar 1, 2021
…test (elastic#92919) * commented code to close out toast # Conflicts: # x-pack/test/security_solution_endpoint/apps/endpoint/policy_details.ts
jloleysens
added a commit
that referenced
this pull request
Mar 3, 2021
… ilm/rollup-v2-action * 'ilm/rollup-v2-action' of github.com:elastic/kibana: (30 commits) Fix expanding document when using saved search data grid (#92999) [SECURITY SOLUTIONS] Bug case connector (#93104) [Security Solution] [Timeline] Bugfix to include unmapped fields in the timeline event details JSON (#92025) [Alerting][Docs] Changed alerting documentation to point to a single source of explaining the configurations. (#92942) [APM] Fix hidden search bar in error pages while loading (#84476) (#93139) [DOCS] Fixes links for machine learning alerts (#92744) [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (#92748) [SecuritySolution][Case] Disable cases on detections in read-only mode (#93010) [Security Solution][Case][Bug] Prevent closing collection when pushing (#93095) [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (#92667) Bump ems landing page to 7.12 (#93065) [App Search] Implement various Relevance Tuning states and form actions (#92644) [actions] for simplistic email servers, set rejectUnauthorized to false (#91760) [Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (#93092) Hide instances latency distribution chart (#92869) [Maps] fix MapboxDraw import from pointing to dist just pointing to folder (#93087) [Maps] fix results trimmed tooltip message doubles feature count for line and polygon features (#92932) [Security Solution][Detecttions] Indicator enrichment tweaks (#92989) [Maps] fix fit to data on heatmap not working (#92697) [Security Solution][Endpoint][Admin] Fixes policy sticky footer save test (#92919) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a failing test where a toast was covering the security solution policy save button, which was recently moved to a sticky footer.