-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Revert security solution cypress file name change #92882
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily disabling security solution Firefox tests. Seem to be race conditions present in the Firefox run specifically causing flake. # Conflicts: # .ci/Jenkinsfile_security_cypress # vars/tasks.groovy
yctercero
added
Feature:CI
Continuous integration
release_note:skip
Skip the PR/issue when compiling release notes
Team:Detections and Resp
Security Detection Response Team
v7.12.0
bug
Fixes for quality problems that affect the customer experience
and removed
Feature:CI
Continuous integration
labels
Feb 25, 2021
yctercero
changed the title
Revert cypres name change
[ci] Revert security solution cypress file name change
Feb 25, 2021
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
brianseeders
approved these changes
Feb 25, 2021
tylersmalley
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified this file does exist.
This was referenced Feb 25, 2021
spalger
approved these changes
Feb 25, 2021
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: cc @yctercero |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team:Detections and Resp
Security Detection Response Team
v7.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the security solution cypress name change #92516 that was backported to 7.12. Originally seemed that update to cypress tests where they were split into chrome and firefox was backported to 7.12, but they weren't. The subsequent PR to disable firefox tests was bacported to 7.12 and this created the issue as it was now looking for a non-existent chrome specific config.