Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Revert security solution cypress file name change #92882

Merged
merged 5 commits into from
Feb 25, 2021

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Feb 25, 2021

Summary

Reverts the security solution cypress name change #92516 that was backported to 7.12. Originally seemed that update to cypress tests where they were split into chrome and firefox was backported to 7.12, but they weren't. The subsequent PR to disable firefox tests was bacported to 7.12 and this created the issue as it was now looking for a non-existent chrome specific config.

yctercero and others added 5 commits February 23, 2021 12:27
Temporarily disabling security solution Firefox tests. Seem to be race conditions present in the Firefox run specifically causing flake.
# Conflicts:
#	.ci/Jenkinsfile_security_cypress
#	vars/tasks.groovy
@yctercero yctercero self-assigned this Feb 25, 2021
@yctercero yctercero added Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team v7.12.0 bug Fixes for quality problems that affect the customer experience and removed Feature:CI Continuous integration labels Feb 25, 2021
@yctercero yctercero changed the title Revert cypres name change [ci] Revert security solution cypress file name change Feb 25, 2021
@yctercero yctercero marked this pull request as ready for review February 25, 2021 18:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this file does exist.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero merged commit 7f5f914 into elastic:7.12 Feb 25, 2021
@yctercero yctercero deleted the revert_cypres_name_change branch October 13, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants