Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ms label from CPU load on status page #92836

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Remove ms label from CPU load on status page #92836

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
083ad9b
Remove ms label from CPU load on status page
joshdover Feb 25, 2021
d485c13
Merge branch 'master' into status-load-label
kibanamachine Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/public/core_app/status/lib/load_status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function formatMetrics({ metrics }: StatusResponse): Metric[] {
defaultMessage: 'Load',
}),
value: [metrics.os.load['1m'], metrics.os.load['5m'], metrics.os.load['15m']],
type: 'time',
type: 'float',
Copy link
Contributor

@TinaHeiligers TinaHeiligers Feb 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshdover The time type was being formatted with a special case. I'm not sure if that's not being read properly or got lost somewhere along the line of platform migration and moving routes around.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's the underlying reason this was happening. Probably something I broke a while back to be honest. I didn't remove it since we're still using this for the response_times metrics.

},
{
name: i18n.translate('core.statusPage.metricsTiles.columns.resTimeAvgHeader', {
Expand Down