Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adding ml_capabilities api tests #92786

Merged
merged 3 commits into from
Feb 25, 2021
Merged

[ML] Adding ml_capabilities api tests #92786

merged 3 commits into from
Feb 25, 2021

Conversation

jgowdyelastic
Copy link
Member

Tests for the ml_capabilities endpoint

@jgowdyelastic jgowdyelastic added review non-issue Indicates to automation that a pull request should not appear in the release notes :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 labels Feb 25, 2021
@jgowdyelastic jgowdyelastic self-assigned this Feb 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 25, 2021
pheyos
pheyos reviewed Feb 25, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to get coverage for this area! 🎉
Just left two suggestions.

x-pack/test/api_integration/apis/ml/system/capabilities.ts Outdated Show resolved Hide resolved
x-pack/test/api_integration/apis/ml/system/space_capabilities.ts Outdated Show resolved Hide resolved
pheyos
pheyos approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

This was referenced Feb 25, 2021
Closed
Closed
@jgowdyelastic jgowdyelastic merged commit 3b66bf7 into elastic:master Feb 25, 2021
@jgowdyelastic jgowdyelastic deleted the ml_capabilities-api-tests branch February 25, 2021 18:24
@kibanamachine kibanamachine mentioned this pull request Feb 25, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 25, 2021
@jgowdyelastic @kibanamachine
[ML] Adding ml_capabilities api tests (elastic#92786)
b399841 
* [ML] Adding ml_capabilities api tests

* updating test text

* changes based on review
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 25, 2021
@jgowdyelastic @kibanamachine
[ML] Adding ml_capabilities api tests (elastic#92786)
696d4ae 
* [ML] Adding ml_capabilities api tests

* updating test text

* changes based on review
@kibanamachine kibanamachine mentioned this pull request Feb 25, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.12 / #92879
✅ 7.x / #92880

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Feb 25, 2021
@kibanamachine @jgowdyelastic
[ML] Adding ml_capabilities api tests (#92786) (#92879)
8229024 
* [ML] Adding ml_capabilities api tests

* updating test text

* changes based on review

Co-authored-by: James Gowdy <[email protected]>
kibanamachine added a commit that referenced this pull request Feb 26, 2021
@kibanamachine @jgowdyelastic
[ML] Adding ml_capabilities api tests (#92786) (#92880)
e94ffbe 
* [ML] Adding ml_capabilities api tests

* updating test text

* changes based on review

Co-authored-by: James Gowdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@pheyos pheyos pheyos approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @pheyos @peteharverson