[Usage Collection] Remove unused applicationUsageTracker from Public API
#92670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Feature:Telemetry
release_note:skip
12 tasks
afharo
force-pushed
the
usage_collection/remove-unused-applicationUsageTracker
branch
from
62f0cd8 to
b3d0ab2
Compare
afharo
force-pushed
the
usage_collection/remove-unused-applicationUsageTracker
branch
from
b3d0ab2 to
42d4b1d
Compare
afharo
added
enhancement
afharo
added
the
auto-backport
mattkime
approved these changes
Feb 25, 2021
|
@elasticmachine merge upstream |
12 tasks
| // This is to avoid having to mock every private property of the class | ||
| type ApplicationUsageTrackerPublic = Pick<ApplicationUsageTracker, keyof ApplicationUsageTracker>; | ||
|
|
||
| export const createApplicationUsageTrackerMock = (): ApplicationUsageTrackerPublic => { |
There was a problem hiding this comment.
We're still using applicationUsageTracker internally so we're not strictly removing it from the code base.
TinaHeiligers
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Code review only: looks fine and cleans up our public API a bit.
One nit though: Can we change the PR title or add to the PR description that we're removing applicationUsageTracker from the public API? ATM, the title can be a little misleading and some folks (like me 😊 ) might interpret it as remove applicationusageTracker from the code base.
afharo
changed the title
applicationUsageTrackerapplicationUsageTracker from Public API
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 1, 2021
…c API (elastic#92670) Co-authored-by: Kibana Machine <[email protected]>
afharo
deleted the
usage_collection/remove-unused-applicationUsageTracker
branch
kibanamachine
added a commit
that referenced
this pull request
Mar 1, 2021
…c API (#92670) (#93076) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Alejandro Fernández Haro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of #91611 we are planning to remove any unused APIs in the Usage Collection service to make it less confusing to other devs, and don't overwhelm them with options.
We can revert this PR in the future if we find any use cases for it.
Checklist
Delete any items that are not applicable to this PR.
For maintainers