[5.x] Fix filters for complex painless scripted fields #9244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports PR #9171 **Commit 1:** Fix filters for complex painless scripted fields Painless scripted fields that consisted of more than a single expression would break when the user attempted to filter on them in Discover or Visualize because of the naive way we were building them. We now wrap the user's script in a lambda so that it can be as complex at they need it to be. The only special exception is that the user cannot define named functions since those cannot go inside a Painless lambda. Fixes #9024 Related elastic/elasticsearch#21635 * Original sha: b2a86bb * Authored by Matthew Bargar <[email protected]> on 2016-11-21T23:18:20Z **Commit 2:** DRY it up * Original sha: 927de50 * Authored by Matthew Bargar <[email protected]> on 2016-11-22T16:21:21Z **Commit 3:** Phrase tests * Original sha: 79e69bd * Authored by Matthew Bargar <[email protected]> on 2016-11-22T16:48:12Z **Commit 4:** Only include necessary comparators and add tests * Original sha: 5b9137b * Authored by Matthew Bargar <[email protected]> on 2016-11-22T17:38:59Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix filters for complex painless scripted fields
Backports PR #9171
Commit 1:
Fix filters for complex painless scripted fields
Painless scripted fields that consisted of more than a single expression
would break when the user attempted to filter on them in Discover or
Visualize because of the naive way we were building them. We now wrap
the user's script in a lambda so that it can be as complex at they need
it to be. The only special exception is that the user cannot define
named functions since those cannot go inside a Painless lambda.
Fixes #9024
Related elastic/elasticsearch#21635
Commit 2:
DRY it up
Commit 3:
Phrase tests
Commit 4:
Only include necessary comparators and add tests