-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude tests from incremental builds #92175
Conversation
…istency with others
This reverts commit 45c1dbd.
Chatted with @tylersmalley and we agree that this is less than ideal and but we don't need to block this PR and we can try to get things better organized as we move to Bazel. This optimization might degrade over time, but ultimately it shouldn't break anything so 👍 |
💔 Build Failed
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
closed in favour of #95610 |
Summary
part of #90281
Cold run before: 6m 31sec
Cold run after: 5m 2sec
This PR adds a centralized
tsconfig.projects.json
for all the plugins and excludes all the test files from being compiled when building TS project references.Instead, I merged
x-pack/tsconfig.json
intotsconfig.json
to keep the single project containing all the test files.Since we have the single
tsconfig
file, I moved all thetypings
to the root level as well.I made several changes to reduce the number of patterns to
exclude
:test_types.ts
renamed totypes.test.ts
/mocks/index.ts
renamed tomocks.ts
/mocks/index.ts
renamed tomocks.ts
/mocks/index.ts
renamed tomocks.ts
test_helpers.tsx
moved undertest_helpers
foldershared_columns_test.tsx
renamed toshared_columns.mock.tsx
enzyme_helpers
__jest__
folder for consistency with other ES-UI proejctstest_data.tsx
tomocks.tsx
test helpers
to/lib/mocks
canvas
utils from js into ts@ts-expect-error
when plugin imported unknown type. It doesn't make sense as a type inferred asany
.