Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App Search] Migrate Create Meta Engine View #92127
[App Search] Migrate Create Meta Engine View #92127
Changes from all commits
d436c4b
cd05bc7
eba36a2
1dc3e90
6627d24
ebaff11
a780e1b
369d82a
76f88c0
6dfc1bd
6c42c62
200802e
753bad1
c999341
23805ed
41da254
3047390
6bae359
04b371f
1c1cc8e
0423d9e
f7741eb
2cd7cd1
31070ee
61b83f8
4a012ce
4736433
65e931c
e9adff2
16a07f3
bd7a05f
6ca7a26
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[follow up from above comment] ah, I guess the main downside is slightly extra cruft for
values
/variables compared to inline copy - hmmmm, I'll percolate on this moreThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these functions in a separate file more than inline fwiw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading this, I'm starting to become more of a fan of putting all our i18n copy into
constants.tsx
files rather than inline - it's nice in that it focuses i18n IDs as well as makes it easier to skim a single file for grammar/sentence casing it. @JasonStoltz any thoughts here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a
i18n.ts
/i18n.tsx
file? They're still "constants" but I think if we intend to keep all of these out of the component.tsx
files I'd rather give them a unique file (and use constants for stuff likeDEFAULT_META
)