-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky core_app integration tests #92030
Conversation
@elasticmachine merge upstream Second run to see if it fails. After 3 successful runs, I'll merge. |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving to unblock in case it gets 3 successive passes.
Imho 3 green runs is far from being good enough to unskip a flaky suite (I mean, it's flaky, not red, 3 runs will likely succeed if the flakiness rate is < 10%, which is most likely the case here) I usually fork the branch, edit the CI group tests to have only this specific test running, then use the flaky runner on 200+ iterations. EDIT: this is not a FTR test. Well in that case, I would edit the IT file to have the test run 200 times, and then revert the commit if/when green. |
Good call @pgayvallet! I've added a loop to run the suite 200 times. It forced me to move some of the vars and setup steps inside the |
The tests passed 200 times in a row after the fixes mentioned in my previous comment: search I'll go ahead and revert the 200 loop. |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
* Unskip core_app integration tests * Run the integration test 200 times * Revert 200 execution loop Co-authored-by: Kibana Machine <[email protected]>
* Unskip core_app integration tests * Run the integration test 200 times * Revert 200 execution loop Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Alejandro Fernández Haro <[email protected]>
Summary
Resolves #81072
Checklist
Delete any items that are not applicable to this PR.
For maintainers