[Uptime] Thumbnail full screen view steps navigation fix #91895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:skip
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @shahzad31 |
shahzad31
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 22, 2021
Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 22, 2021
Co-authored-by: Kibana Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 22, 2021
* master: (36 commits) [Uptime] Thumbnail full screen view steps navigation fix (elastic#91895) Implement ScopedHistory.block (elastic#91099) [Lens] Fix overlowing content on a chart for charts and table (elastic#92006) handle source column differences in embeddable as well (elastic#91987) [Vega] [Map] disable map rotation using right right click / touch rotation gesture (elastic#91996) [Lens] Load indexpatterns list from indexPattern Service (elastic#91984) [coverage] ingest data in parallel (elastic#92074) [Lens] Drag and drop performance improvements (elastic#91641) A few more environment uiFilters fixes (elastic#92044) Enabling Uptime and Dashboard a11y test (elastic#91017) [Security Solution][Detections] Adds more granular validation for nested fields (elastic#92041) [Security Solution] [Detections] add overflow-wrap for description (elastic#91945) [Security Solution] [Detections] do not truncate filename in value list table in modal (elastic#91952) Skip flaky apm test elastic#91673 (elastic#92065) [docker] Default server.name to hostname (elastic#90799) Use documentation link service for snapshot restore (elastic#91596) [Security Solution] Clearing up all jest errors and warnings (elastic#91740) Add `@kbn/analytics` to UI Shared Deps (elastic#91810) [7.12][Telemetry] Add missing fields for security telemetry (elastic#91920) [Security Solution] Adds cypress-pipe (elastic#91550) ...
kibanamachine
added a commit
that referenced
this pull request
Feb 22, 2021
…2147) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Shahzad <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 22, 2021
…2148) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Shahzad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #91999
In ping list browser view, we show thumbnail, clicking it leads to you full screen view, where you can navigate between step screenshots, it was broken in a way, that if you navigate to 2nd step and then tries to view first step, it always kept the second step screenshot.
This PR fixes that bug.
Also clicking too many leads to unexpected behaviour, added a loading state prevent that.