Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI][Metrics UI] Lazy load alert types #91674

Closed
wants to merge 1 commit into from

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Feb 17, 2021

Summary

Part of #89025. Lazy load alert types on plugin initialization to reduce the size of the infra bundle.

@afgomez afgomez added Feature:Metrics UI Metrics UI feature v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes performance technical debt Improvement of the software architecture and operational architecture labels Feb 17, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.9MB 2.1MB +160.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 190.1KB 114.3KB -75.8KB
Unknown metric groups

async chunk count

id before after diff
infra 14 20 +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez
Copy link
Contributor Author

afgomez commented Feb 22, 2021

Closing since we are not going to merge it. It was a good experiment to see what's possible with lazy loading, but I think we want to better understand how and what to lazy load.

@afgomez afgomez closed this Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature performance release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services technical debt Improvement of the software architecture and operational architecture v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants