-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Telemetry: Add UI usage telemetry on the Timeseries comparison feature #91439
[APM] Telemetry: Add UI usage telemetry on the Timeseries comparison feature #91439
Conversation
Pinging @elastic/apm-ui (Team:apm) |
x-pack/plugins/apm/public/components/shared/time_comparison/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. just had one question
One more question: will we still fetch comparison data after this PR (I guess yes). I don't want to complicate things but would be optimal if we don't retrieve the comparison data since it's never used. |
@sqren this is not the PR the removes the time comparison on all pages, it only removes from service inventory, transactions overview and transaction details, it is still available on service overview. I'm going to work on another PR to entirely disable it for 7.12. |
@elasticmachine merge upstream |
…ibana into apm-comparison-telemetry
@formgeist I'd like to double check with you what I did:
|
@cauemarcondes Yup, those two interactions are critical to understanding if users tend to turn off comparisons more often and if users switch the default comparison periods. |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…feature (elastic#91439) * adding telemetry and removing time comparison * adding telemetry and removing time comparison * adding telemetry Co-authored-by: Kibana Machine <[email protected]>
…feature (#91439) (#94715) * adding telemetry and removing time comparison * adding telemetry and removing time comparison * adding telemetry Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
closes #90626
Adds telemetry to the time comparison feature.