-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Anomaly Detection alert initialisation from the ML app #91283
[ML] Anomaly Detection alert initialisation from the ML app #91283
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
@@ -37,6 +37,7 @@ export const emptyMlCapabilities: MlCapabilitiesResponse = { | |||
canDeleteDataFrameAnalytics: false, | |||
canCreateDataFrameAnalytics: false, | |||
canStartStopDataFrameAnalytics: false, | |||
canCreateMlAlerts: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, is there any expectation we check this permission and restrict access within Detections for creating ML Rules? I imagine no since the Detection Engine is managed as a separate application, and this seems specific to the new ML Alert Type, but want to make sure we're respecting permissions as expected from the ML permissions model perspective.
i.e Should we disable the ML Detections Rule type if canCreateMlAlerts:false
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @spong! 👋 I reckon canCreateMlAlerts
should not affect the ML Detections Rule in Security app, as it's dedicated to the ML related alert types only. No actions are required on your side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security Solution changes LGTM! One outstanding question on if we should be respecting the new canCreateMlAlerts
ML permission within the Detection Engine, but we can open a dedicated issue to address if necessary. Thanks @darnautov! 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Backport result
|
Summary
Part of #88940
Allows initializing the Anomaly Detection alert directly in the Job wizard

Allows initializing the Anomaly Detection alert from the Job list with single and bulk actions

Adds "Create alert" action to the jobs management table


Adds control for including/excluding interim results

Removes Watcher integration from the ML plugin
Checklist
Delete any items that are not applicable to this PR.