Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Enabling Grok Debugger Functional UI Tests #91274

Merged

Conversation

cuff-links
Copy link
Contributor

@cuff-links cuff-links commented Feb 12, 2021

Closes #84440

Summary

I am using this PR to test failures in the Grok debugger suite. I cannot reproduce them locally even using network throttling and headless mode.

@cuff-links
Copy link
Contributor Author

I ran this suite 200 times with no failures. There was a timeout exceeded but I think that the actual job hung (might have stressed the workers or something). https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1303/

@cuff-links cuff-links changed the title Adding .only clause for testing purposes. Exploring Flaky Tests In Grok Debugger Feb 19, 2021
@cuff-links
Copy link
Contributor Author

@elasticmachine merge upstream

@cuff-links
Copy link
Contributor Author

cuff-links commented Mar 17, 2021

@cuff-links
Copy link
Contributor Author

I think we can unskip this test to get it running in CI again and if there is a failure again, we reinvestigate. It has ran a total of 350 times without any failures.

@cuff-links cuff-links changed the title Exploring Flaky Tests In Grok Debugger Re-Enabling Grok Debugger Functional Tests Mar 17, 2021
@cuff-links cuff-links requested a review from spalger March 17, 2021 19:01
@cuff-links cuff-links marked this pull request as ready for review March 17, 2021 19:01
@cuff-links cuff-links added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.12.1 Feature:Functional Testing Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Mar 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cuff-links cuff-links added the Feature:Grok Debugger Dev Tools Grok Debugger feature label Mar 17, 2021
@cuff-links cuff-links changed the title Re-Enabling Grok Debugger Functional Tests Re-Enabling Grok Debugger Functional UI Tests Mar 17, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cuff-links cuff-links merged commit 6df27f3 into elastic:master Mar 18, 2021
@cuff-links cuff-links added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 18, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 18, 2021
* Adding .only clause for testing purposes.

* Removing .only and reenabling test. Also changing back to group 13.

* Removing .only and reenabling test. Also changing back to group 13.

* Removed comment mentioning github issue.

Co-authored-by: Kibana Machine <[email protected]>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 18, 2021
* Adding .only clause for testing purposes.

* Removing .only and reenabling test. Also changing back to group 13.

* Removing .only and reenabling test. Also changing back to group 13.

* Removed comment mentioning github issue.

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.12 / #94996
7.x / #94997

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 19, 2021
* Adding .only clause for testing purposes.

* Removing .only and reenabling test. Also changing back to group 13.

* Removing .only and reenabling test. Also changing back to group 13.

* Removed comment mentioning github issue.

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: John Dorlus <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 19, 2021
* Adding .only clause for testing purposes.

* Removing .only and reenabling test. Also changing back to group 13.

* Removing .only and reenabling test. Also changing back to group 13.

* Removed comment mentioning github issue.

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: John Dorlus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Functional Testing Feature:Grok Debugger Dev Tools Grok Debugger feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.12.1 v7.13.0 v8.0.0
Projects
None yet
4 participants